Re: Patch for Bug#120386: lilo misconfigured

2002-02-01 Thread Matt Kraai
On Sat, Feb 02, 2002 at 01:02:22AM +0100, Michael Tiedtke wrote: > This solves the bug, but could someone please explain me why it > doesn't work in the original code? Sure. The parentheses are wrong. The equality test has higher precedence than the assignment, so it assigns the comparison resu

Re: Patch for Bug#120386: lilo misconfigured

2002-02-01 Thread Marcin Owsiany
On Sat, Feb 02, 2002 at 01:02:22AM +0100, Michael Tiedtke wrote: > This solves the bug, but could someone please explain me why it > doesn't work in the original code? > > Old: >if ( (res = menuBox(prtbuf, _("Where should the LILO boot loader be installed?"), >opt, 2, 1) == -1 )) >... >

Patch for Bug#120386: lilo misconfigured

2002-02-01 Thread Michael Tiedtke
This solves the bug, but could someone please explain me why it doesn't work in the original code? Old: if ( (res = menuBox(prtbuf, _("Where should the LILO boot loader be installed?"), opt, 2, 1) == -1 )) ... The return value of menuBox is not assigned to res. It still has the inital va