Re: Refactoring commit_changes in partman

2007-12-04 Thread Frans Pop
On Tuesday 04 December 2007, Max Vozeler wrote: > > And please commit today so it's in before I start the restructuring. > > OK, I've commited the changes. Thanks Max. > I think it would be useful to do a quick round of > uploads before starting the reorganization, so that we > have a known basel

Re: Refactoring commit_changes in partman

2007-12-04 Thread Max Vozeler
On Tue, Dec 04, 2007 at 04:40:03PM +0100, Frans Pop wrote: > On Tuesday 04 December 2007, Frans Pop wrote: > > On Tuesday 04 December 2007, Max Vozeler wrote: > > > Yes, I've tested -auto-crypto, -auto-lvm, -md, -lvm, -crypto > > > and -partitioning by doing some random setups and injected the > >

Re: Refactoring commit_changes in partman

2007-12-04 Thread Frans Pop
On Tuesday 04 December 2007, Frans Pop wrote: > On Tuesday 04 December 2007, Max Vozeler wrote: > > Yes, I've tested -auto-crypto, -auto-lvm, -md, -lvm, -crypto > > and -partitioning by doing some random setups and injected the > > two error cases with failing commit.d/init.d scripts. > > Perfect.

Re: Refactoring commit_changes in partman

2007-12-04 Thread Frans Pop
On Tuesday 04 December 2007, Max Vozeler wrote: > Yes, I've tested -auto-crypto, -auto-lvm, -md, -lvm, -crypto > and -partitioning by doing some random setups and injected the > two error cases with failing commit.d/init.d scripts. Perfect. > I didn't test -dmraid because I couldn't figure out ho

Re: Refactoring commit_changes in partman

2007-12-03 Thread Max Vozeler
Hi Frans, On Mon, Dec 03, 2007 at 10:37:32AM +0100, Frans Pop wrote: > On Monday 03 December 2007, Max Vozeler wrote: > > I've carefully gone through them and noted the differences, > > hoping to replace them all with a common commit_changes in > > partman-base/definition.sh > > I agree that fact

Re: Refactoring commit_changes in partman

2007-12-03 Thread Frans Pop
On Monday 03 December 2007, Max Vozeler wrote: > I've carefully gone through them and noted the differences, > hoping to replace them all with a common commit_changes in > partman-base/definition.sh I agree that factoring this out makes sense. I've looked over your patch and the thorough analysis

Re: Refactoring commit_changes in partman

2007-12-02 Thread Max Vozeler
Hey all, On Mon, Dec 03, 2007 at 12:10:45AM +0100, Max Vozeler wrote: > o I plan to apply the attached path if noone voices >objections. .. Sorry, I attached an earlier revision of the patch. Please see this one instead. Max Index: partman-crypto/debian/control ===

Refactoring commit_changes in partman

2007-12-02 Thread Max Vozeler
Hey all, most of the partman-* packages provide their own slightly different version of commit_changes. I've carefully gone through them and noted the differences, hoping to replace them all with a common commit_changes in partman-base/definition.sh o I plan to apply the attached path if noone