Re: [pkg-ntp-maintainers] Bug#653771: FTBFS on kfreebsd-* due to -Wformat-security

2011-12-31 Thread Steven Chamberlain
On 31/12/11 20:48, Peter Eisentraut wrote: > On fre, 2011-12-30 at 23:29 +, Steven Chamberlain wrote: >> My new patch (attached) fixes only those parts, and I am now able to >> build successfully on kfreebsd-i386. > > Why did you change printf to fprintf(stdout, ...)? Hi, I saw it written th

Re: [pkg-ntp-maintainers] Bug#653771: FTBFS on kfreebsd-* due to -Wformat-security

2011-12-31 Thread Peter Eisentraut
On fre, 2011-12-30 at 23:29 +, Steven Chamberlain wrote: > My new patch (attached) fixes only those parts, and I am now able to > build successfully on kfreebsd-i386. Why did you change printf to fprintf(stdout, ...)? -- To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org with a su

Re: [pkg-ntp-maintainers] Bug#653771: FTBFS on kfreebsd-* due to -Wformat-security

2012-01-03 Thread Peter Eisentraut
I think the below is a more correct fix. Could you check whether it works for you? --- a/ntpd/refclock_oncore.c +++ b/ntpd/refclock_oncore.c @@ -4058,7 +4058,7 @@ oncore_log ( snprintf(Msg, sizeof(Msg), "ONCORE[%d]: %s", instance->unit, msg); - syslog(log_level, M

Re: [pkg-ntp-maintainers] Bug#653771: FTBFS on kfreebsd-* due to -Wformat-security

2012-01-04 Thread Steven Chamberlain
On 03/01/12 21:51, Peter Eisentraut wrote: > I think the below is a more correct fix. Could you check whether it > works for you? Hi Peter, Your suggestion builds okay on kfreebsd-i386, it prevents the -Wformat-security warning, and it runs fine. I've copied your patch and mine to upstream to s