Your message dated Wed, 17 Jan 2007 00:36:17 +0100
with message-id <[EMAIL PROTECTED]>
and subject line Fixed: supertux: 1up sound playing inconsistent with 99 lives
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: supertux
Version: 0.1.1-1
Severity: minor
Tags: patch

After reaching MAX_LIVES SND_LIFEUP only plays when DISTROS_LIFEUP is
reached, not when a 1up is caught.  To me, this seems inconsistent and
the patch follows the comment on line 525 of player.cpp:

  /*We want to hear the sound even, if MAX_LIVES is reached*/

diff -ru supertux-0.1.1.old/src/special.cpp supertux-0.1.1/src/special.cpp
--- supertux-0.1.1.old/src/special.cpp  2004-04-28 20:15:10.000000000 -0400
+++ supertux-0.1.1/src/special.cpp      2004-07-12 20:50:29.000000000 -0400
@@ -348,8 +348,8 @@
         {
           if(player_status.lives < MAX_LIVES) {
             player_status.lives++;
-            play_sound(sounds[SND_LIFEUP], SOUND_CENTER_SPEAKER);
           }
+          play_sound(sounds[SND_LIFEUP], SOUND_CENTER_SPEAKER);
         }

       remove_me();

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.7-ck5
Locale: LANG=C, LC_CTYPE=C

Versions of packages supertux depends on:
ii  libc6                     2.3.2.ds1-13   GNU C Library: Shared libraries an
ii  libgcc1                   1:3.3.4-3      GCC support library
ii  libsdl-image1.2           1.2.3-3        image loading library for Simple D
ii  libsdl-mixer1.2           1.2.5-6        mixer library for Simple DirectMed
ii  libsdl1.2debian           1.2.7-7        Simple DirectMedia Layer
ii  libstdc++5                1:3.3.4-3      The GNU Standard C++ Library v3
ii  supertux-data             0.1.1-1        Levels for classic 2D jump 'n run 
ii  xlibmesa-gl [libgl1]      4.3.0.dfsg.1-6 Mesa 3D graphics library [XFree86]
ii  zlib1g                    1:1.2.1.1-5    compression library - runtime

-- no debconf information


--- End Message ---
--- Begin Message ---
Version: 0.3.0~dfsg-1

Hi,

since the 0.3.0 version, picking an 1up bonus increases the gold coin
numbers and no longer a life number, so I guess that one can close this
bugreport safely.

Feel free to reopen it if you don't share my opinion, your thoughts are
of course welcome.

Cheers,

-- 
Cyril Brulebois

Attachment: pgpfIXJzPyIrD.pgp
Description: PGP signature


--- End Message ---

Reply via email to