Your message dated Thu, 19 Feb 2009 04:32:04 +0000
with message-id <e1la0zw-0007ft...@ries.debian.org>
and subject line Bug#491159: fixed in spamassassin 3.2.5-3
has caused the Debian Bug report #491159,
regarding spamassassin: sa-learn tries to read a message from stdin if given an 
empty message/folder list
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
491159: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=491159
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: spamassassin
Version: 3.2.5-1
Severity: normal
Tags: patch


$ sa-learn -f /dev/stdin < /dev/null
Learned tokens from 1 message(s) (1 message(s) examined)

I call sa-learn in a script, and give it a list of messages that I
know are ham or spam, using -f.  Sometimes the list is empty, and to
my surprise sa-learn always reports that it has learned from 1
message.

The problem is that on line 379, sa-learn decides that if its list of
targets is empty, it must be reading a message from stdin.  But that's
not true if it's been given an empty list of messages.  The attached
patch corrects the error.

Thanks,
Andrew.

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (300, 'unstable'), (200, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1) (ignored: LC_ALL set to 
en_US)
Shell: /bin/sh linked to /bin/bash

Versions of packages spamassassin depends on:
ii  libdigest-sha1-perl           2.11-2+b1  NIST SHA-1 message digest algorith
ii  libhtml-parser-perl           3.56-1+b1  A collection of modules that parse
ii  libnet-dns-perl               0.63-2     Perform DNS queries from a Perl sc
ii  libsocket6-perl               0.20-1     Perl extensions for IPv6
ii  libsys-hostname-long-perl     1.4-2      Figure out the long (fully-qualifi
ii  libwww-perl                   5.812-1    WWW client/server library for Perl
ii  perl                          5.10.0-11  Larry Wall's Practical Extraction 
ii  perl-modules [libarchive-tar- 5.10.0-11  Core Perl modules

Versions of packages spamassassin recommends:
ii  gcc                           4:4.3.1-1  The GNU C compiler
ii  gnupg                         1.4.9-2    GNU privacy guard - a free PGP rep
ii  libc6-dev                     2.7-10     GNU C Library: Development Librari
pn  libmail-spf-perl              <none>     (no description available)
pn  libsys-syslog-perl            <none>     (no description available)
ii  make                          3.81-5     The GNU version of the "make" util
pn  re2c                          <none>     (no description available)
ii  spamc                         3.2.5-1    Client for SpamAssassin spam filte

-- no debconf information
--- /usr/bin/sa-learn.orig      2008-07-17 05:58:03.000000000 -0400
+++ /usr/bin/sa-learn   2008-07-17 05:58:05.000000000 -0400
@@ -376,7 +376,7 @@
 
   my $tempfile; # will be defined if stdin -> tempfile
   push(@targets, @ARGV);
-  @targets = ('-') unless @targets;
+  @targets = ('-') unless @targets || $opt{folders};
 
   for(my $elem = 0; $elem <= $#targets; $elem++) {
     # ArchiveIterator doesn't really like STDIN, so if "-" is specified

--- End Message ---
--- Begin Message ---
Source: spamassassin
Source-Version: 3.2.5-3

We believe that the bug you reported is fixed in the latest version of
spamassassin, which is due to be installed in the Debian FTP archive:

spamassassin_3.2.5-3.diff.gz
  to pool/main/s/spamassassin/spamassassin_3.2.5-3.diff.gz
spamassassin_3.2.5-3.dsc
  to pool/main/s/spamassassin/spamassassin_3.2.5-3.dsc
spamassassin_3.2.5-3_all.deb
  to pool/main/s/spamassassin/spamassassin_3.2.5-3_all.deb
spamc_3.2.5-3_i386.deb
  to pool/main/s/spamassassin/spamc_3.2.5-3_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 491...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Noah Meyerhans <no...@debian.org> (supplier of updated spamassassin package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 18 Feb 2009 22:15:20 -0500
Source: spamassassin
Binary: spamassassin spamc
Architecture: source all i386
Version: 3.2.5-3
Distribution: unstable
Urgency: low
Maintainer: no...@debian.org
Changed-By: Noah Meyerhans <no...@debian.org>
Description: 
 spamassassin - Perl-based spam filter using text analysis
 spamc      - Client for SpamAssassin spam filtering daemon
Closes: 491159
Changes: 
 spamassassin (3.2.5-3) unstable; urgency=low
 .
   * Add an alternate dependency on libio-zlib-perl (>= 1.04) to ease
     backporting (yeah, should have been done three uploads ago...)
   * Set myself as the Maintainer per Duncan's request.
   * Explicity set a umask (022) in /etc/cron.daily/spamassassin
   * Don't compress GPG.KEY, since we need to use it during postinst and
     it's small.
   * Add Andrew Schulman's fix for sa-learn to properly handle a case
     where an empty folder list is given as a source of training data.
     (Closes: 491159)
Checksums-Sha1: 
 65c68c3c9df7972d167ed40cbb19a28d77d4ab55 1366 spamassassin_3.2.5-3.dsc
 ff817c283070e4e0657accf1c8393980c07e4364 34243 spamassassin_3.2.5-3.diff.gz
 91704878451c51f02d163701de3574877398828f 1098316 spamassassin_3.2.5-3_all.deb
 80ba74c34823c470d386ce73c91408c0717d1847 72554 spamc_3.2.5-3_i386.deb
Checksums-Sha256: 
 0d04b912a21ce598bd0c8668970c4b3644c74f5c81cdfb2e717ec834150c7af7 1366 
spamassassin_3.2.5-3.dsc
 1852b273701cd571b440024aed14418aea77bafe33a4838f7a1bc57cbc30f47a 34243 
spamassassin_3.2.5-3.diff.gz
 c8752482bd9bbfffc38c1cd133fd5d162ec00a073b99652ddc8da8fe31e8b1b2 1098316 
spamassassin_3.2.5-3_all.deb
 fc5a1281e832ea8ee71f6be4ec0c30978e9210ee18eb1107879d0f5184db6027 72554 
spamc_3.2.5-3_i386.deb
Files: 
 41b14067a107be87751836f98d1bd164 1366 mail optional spamassassin_3.2.5-3.dsc
 13ebf0f4f82b743c7f1425d654fd7cb1 34243 mail optional 
spamassassin_3.2.5-3.diff.gz
 6752b3b5c8bd9c22bd46da170e784fac 1098316 mail optional 
spamassassin_3.2.5-3_all.deb
 c8929db20766fec006d588dd1e73314f 72554 mail optional spamc_3.2.5-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFJnN6cYrVLjBFATsMRAoMIAJoDKrfL1R0AnftEM1wHutwTySs28ACfWtlV
1QirVTAGf+B163nhLu9Esgk=
=qHTh
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to