Your message dated Wed, 18 Feb 2009 18:47:02 +0000 with message-id <e1lzrrm-0007uu...@ries.debian.org> and subject line Bug#514938: fixed in initramfs-tools 0.93 has caused the Debian Bug report #514938, regarding find/cpio exit codes ignored while building initramfs to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 514938: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=514938 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: initramfs-tools Version: 0.92o Severity: normal Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu jaunty ubuntu-patch The final stage of mkinitramfs that builds the image does not verify the exit codes of find or cpio: (cd "${DESTDIR}" && find . | cpio --quiet --dereference -o -H newc | gzip >"${outfile}") || exit 1 Once bug 514936 is solved, this will be even more important, since cpio will actually return errors. In bash, there is support for checking more than just the final pipe command's exit code via the "pipefail" option. Attached patch adds this behavior, and make sure the script uses bash (to avoid future dash/bash migration issues). Current behavior: $ find /fail | cpio --quiet --dereference -o -H newc | gzip > /tmp/archive.gz find: `/fail': No such file or directory $ echo $? 0 Desired behavior: $ set -o pipefail $ find /fail | cpio --quiet --dereference -o -H newc | gzip > /tmp/archive.gz find: `/fail': No such file or directory $ echo $? 1 Also, I would recommend adding "-e" to the shell to catch single-command failures during execution, though that's out of scope for this particular bug. Thanks! -Kees -- Kees Cook @debian.org--- mkinitramfs~ 2009-02-11 17:18:41.000000000 -0800 +++ mkinitramfs 2009-02-11 17:19:40.000000000 -0800 @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash umask 0022 export PATH='/usr/bin:/sbin:/bin' @@ -296,6 +296,7 @@ fi [ "${verbose}" = y ] && echo "Building cpio ${outfile} initramfs" +set -o pipefail (cd "${DESTDIR}" && find . | cpio --quiet --dereference -o -H newc | gzip >"${outfile}") || exit 1 if [ -s "${__TMPCPIOGZ}" ]; then
--- End Message ---
--- Begin Message ---Source: initramfs-tools Source-Version: 0.93 We believe that the bug you reported is fixed in the latest version of initramfs-tools, which is due to be installed in the Debian FTP archive: initramfs-tools_0.93.dsc to pool/main/i/initramfs-tools/initramfs-tools_0.93.dsc initramfs-tools_0.93.tar.gz to pool/main/i/initramfs-tools/initramfs-tools_0.93.tar.gz initramfs-tools_0.93_all.deb to pool/main/i/initramfs-tools/initramfs-tools_0.93_all.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 514...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. maximilian attems <m...@debian.org> (supplier of updated initramfs-tools package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Wed, 18 Feb 2009 19:10:23 +0100 Source: initramfs-tools Binary: initramfs-tools Architecture: source all Version: 0.93 Distribution: unstable Urgency: low Maintainer: Debian kernel team <debian-ker...@lists.debian.org> Changed-By: maximilian attems <m...@debian.org> Description: initramfs-tools - tools for generating an initramfs Closes: 472409 488804 489008 497133 504551 509637 511514 512453 513958 514938 514997 515866 Changes: initramfs-tools (0.93) unstable; urgency=low . Release "Fischia il vento e infuria la bufera" . [ maximilian attems ] * manpages: Set Linux as necessary OS. * initramfs-tools.8: Fix path of debug log - now kept after boot. (closes: #488804) * mkinitramfs: Use cp with correct DESTDIR instead of copy_exec for configs. Fixes relative pathes for -d option. (closes: #472409) * initramfs-tools.8: Document default 180s rootdelay. * update-initramfs: Fix run_bootloader() to check for grub2. (closes: #511514) * control: Add ${misc:Depends} depends. * nuke old lvm hook scripts. * mkinitramfs-kpkg: deprecate it's usage. * hook-functions: just ship old iee1394 if around. * mkinitramfs: Post-Lenny cleanup. * udevhelper: nuke as need for partial upgrades between etch/lenny. * mkinitramfs: Fix new pipe construct to really work inside "${DESTDIR}". * thermal boot script: Don't load thermal+fan on acpi=off. (closes: #514997) * MODULES=dep fix for minor partitions > 9. (closes: #513958) * initramfs-tools.8: Document mkinitramfs and init env variables. (closes: #512453) * init: Fix boot with LABEL containting one or several '/'. Thanks to Andres Salomon <dilin...@debian.org> for testing. (closes: #489008) * scripts/local-premount/resume: Fix resume with LABEL containing '/'. . [ e2xbegqsdyt21hfc ] * update-initramfs.8: mentions the specific conf file. . [ Kel Modderman ] * init: variable `break' unset before `maybe_break init' is evaluated. (closes: #509637) . [ Kees Cook ] * minitramfs: find/cpio exit codes ignored while building initramfs. (closes: #514938) * mkinitramfs: Do not pass exit code through on pipe failure. . [ Luke Yelavich ] * hook-functions: Add hid_* modules, since some keyboards will not be usable at the initramfs/busybox prompt without them. (closes: #515866) . [ Andres Salomon ] * allow root=mtd0 to be used; skip root checks if ROOT doesn't start with /dev. (closes: #497133) * initramfs-tools: Readd support for linux-2.6 make deb-pkg target. (closes: #504551) . [ Ian Campbell ] * MODULES=dep fix for Xen virtual block devices. Checksums-Sha1: 925f6476bf08b48217cc3c324afe85954faae3a4 1000 initramfs-tools_0.93.dsc 0de5f75283c42dd78dd172c93ce59b23e70b2f4f 78812 initramfs-tools_0.93.tar.gz 755265561a524e699af71b3036c5b7071deed7b8 74342 initramfs-tools_0.93_all.deb Checksums-Sha256: 5fad42a4d13f9eaaddd7e4b2d799245719daa4d13b749c2fc10ff63b666c6ffa 1000 initramfs-tools_0.93.dsc 1d56acc8dd64504d1e383a9e671179979369624323814ea691bceaa3560e0ec7 78812 initramfs-tools_0.93.tar.gz 333353a71b38314ddc65f79f700f0e354cc6cc61fba847a10b6691d1557dc6da 74342 initramfs-tools_0.93_all.deb Files: d9d12917112fe7cd57bc25f8ab028ba2 1000 utils optional initramfs-tools_0.93.dsc 97b6188728c9ecacd21e9b4f06a3e86a 78812 utils optional initramfs-tools_0.93.tar.gz a7c421c1377d361e50abd8e6a011eff3 74342 utils optional initramfs-tools_0.93_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkmcVW4ACgkQeW7Lc5tEHqhKGgCaArxtMs4E4Wh6BK1sISETj3m9 o4gAnRvc0POhky/NA3vMaEBD9V6pq0G9 =IGxF -----END PGP SIGNATURE-----
--- End Message ---
