Bug#783929: [mnemosyne-proj-devel] SM-2 bug with patch

2015-05-03 Thread Peter Bienstman
But rule 6 says not to apply rule 5 for failed cards: If the quality response was lower than 3 then start repetitions for the item from the beginning without changing the E-Factor It doesn't say that. It says that rule 6 applies only to cards with grades 0 and 1. It doesn't and

Bug#783929: [mnemosyne-proj-devel] SM-2 bug with patch

2015-05-03 Thread Peter Bienstman
Done. Peter On 3 May 2015 19:32:54 CEST, Astrid S. de Wijn astrid-spamme...@syonax.net wrote: On Sun, May 03, 2015 at 06:30:03PM +0200, Peter Bienstman wrote: But if that is ok, because the precise algorithm is not important for what you want to do with this data

Bug#783929: [mnemosyne-proj-devel] SM-2 bug with patch

2015-05-02 Thread Peter Bienstman
Hi, Thanks for looking into this! However, when I wrote this code many years ago, I had a feeling the original SM2 algorithm could use a few tweaks, especially when dealing with early / late review, and the fact that there should be a small difference between grades 0 and 1. So, I'm afraid

Bug#783929: [mnemosyne-proj-devel] SM-2 bug with patch

2015-05-02 Thread Peter Bienstman
this bug, there is in fact no difference at all between grades 0 and 1. There is no difference in terms of easiness, but cards with grade 0 show up more often in the queue. Worse, cards that the user reviews precisely on time, but fails to recall (grade 0 or 1) end up with higher

Bug#783929: [mnemosyne-proj-devel] SM-2 bug with patch

2015-05-02 Thread Peter Bienstman
It is rule 5 of the SM2 algorithm that is not being executed at all for cards graded 0 or 1 But rule 6 says not to apply rule 5 for failed cards: If the quality response was lower than 3 then start repetitions for the item from the beginning without changing the E-Factor I guess the