Hello Mathias, thank you for going through my packages in-depth.
* The typical pattern for new source packages in Debian is to have an
ITP filed, which is then closed on the first upload. Right now you have
an ITP that's covering both source packages. I'd suggest modifying the
existing ITP
Hi Ben,
I spent some time reviewing the packaging for makemkv-{bin,oss}
today. Here are some thoughts/comments.
General notes:
* The typical pattern for new source packages in Debian is to have an
ITP filed, which is then closed on the first upload. Right now you have
an ITP that's
On Tue, 2022-01-18 at 18:31 -0500, Ben Westover wrote:
> Hello again, I've fixed some problems.
>
> > It dawned on me last night that maybe a simple use of
> > dh_install(1)'s
> > d/*.install file may be sufficient when coupled with a stub
> > d/rules.
> > Compat level 13 and later support
Hi Ben,
I just had a quick look at your package because I didn't even know makemkv
came in a version that could be considered "oss" :)
I found your debian/watch file a bit peculiar,
version=4
opts="" \
https://www.makemkv.com/forum/viewtopic.php?t=224
On Tue, Jan 18, 2022 at 07:22:30PM -0500, Ben Westover wrote:
> > looking at the linked forum it seems a new post is made for every release,
> > so the topic ID above is unlikely to stay the same, no?
> >
> > It seems to me that rather defeats the purpose of a watch file.
>
> The forum post
Hello Daniel,
I found your debian/watch file a bit peculiar,
version=4
opts="" \
https://www.makemkv.com/forum/viewtopic.php?t=224
.*/download/makemkv-bin-(\d\S+)\.tar\.gz
looking at the linked forum it seems a new post is made for every release,
so the topic ID above is
Hello again, I've fixed some problems.
It dawned on me last night that maybe a simple use of dh_install(1)'s
d/*.install file may be sufficient when coupled with a stub d/rules.
Compat level 13 and later support variable substitution, which may
allow the architecture-specific path to be used
On Mon, 2022-01-17 at 14:51 -0500, Ben Westover wrote:
> Hello, Mathias!
>
> > It looks like you're basing your packaging work off of the
> > packages
> > I've created and made available; that's wonderful, and I'm glad
> > they
> > were a good starting point. However, I think it would be
> >
Hello, Mathias!
It looks like you're basing your packaging work off of the packages
I've created and made available; that's wonderful, and I'm glad they
were a good starting point. However, I think it would be appropriate
(at a minimum) to provide credit in d/copyright.
Here's the story: I
Hi Ben!
On Sun, 2022-01-16 at 20:51 -0500, Ben Westover wrote:
> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
> I am looking for a sponsor for my packages "makemkv-oss" and
> "makemkv-bin" (they depend on each other):
It's great that you're working on the packaging
Package: sponsorship-requests
Severity: wishlist
Dear mentors,
I am looking for a sponsor for my packages "makemkv-oss" and
"makemkv-bin" (they depend on each other):
* Package name: makemkv-oss
Version : 1.16.5-1
* URL : https://makemkv.com/
* License :
11 matches
Mail list logo
