Package: hydra
Version: 9.2-1
Severity: normal
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu jammy

Dear Maintainer,

This bug report was also filed in Ubuntu and can be found at
https://launchpad.net/bugs/1959622

Hydra will FTBFS when building against openssl 3.0 for want of a INT_MAX
definition.  I confirmed this in a sid container with openssl from
experimental.

In file included from hydra-mod.c:8:
/usr/include/openssl/err.h: In function ‘ERR_GET_LIB’:
/usr/include/openssl/err.h:243:9: error: ‘INT_MAX’ undeclared
(first use in this function)
243 |     if (ERR_SYSTEM_ERROR(errcode))
/usr/include/openssl/err.h:31:1: note: ‘INT_MAX’ is defined in header
‘<limits.h>’; did you forget to ‘#include <limits.h>’?

limits.h does get included, but a conflict between the hydra configure file and
the de-facto package layout of libmemcached-dev means that the wrong limits.h
file, then one from memcached, is included.

Also sent upstream - https://github.com/vanhauser-thc/thc-hydra/pull/718

See attached patch.

-Dan
diff -Nru hydra-9.2/debian/patches/10_memcached_include.diff 
hydra-9.2/debian/patches/10_memcached_include.diff
--- hydra-9.2/debian/patches/10_memcached_include.diff  1969-12-31 
17:00:00.000000000 -0700
+++ hydra-9.2/debian/patches/10_memcached_include.diff  2022-01-31 
14:45:37.000000000 -0700
@@ -0,0 +1,28 @@
+Description: Adjust memcached include dir lookup to not shadow limits.h
+ Compilation against openssl 3.0 causes a failure to find INT_MAX, despite the
+ openssl headers including limits.h.  However, the fact that the
+ libmemcached-dev package provides both /usr/include/libmemcached{,-1.0}
+ directories, both of which contain memcached.h, mean that MCACHED_IPATH ends
+ up set to the libmemcached-1.0 one, which contains a limits.h, which shadows
+ /usr/include/limits.h.
+ Don't do that.
+Author: Dan Bungert <daniel.bung...@canonical.com>
+Bug-Ubuntu: https://launchpad.net/bugs/1959622
+Forwarded: https://github.com/vanhauser-thc/thc-hydra/pull/718
+Last-Update: 2022-01-31
+--- a/configure
++++ b/configure
+@@ -998,11 +998,9 @@
+     if [ "X" = "X$MCACHED_IPATH" ]; then
+         if [ -f "$i/memcached.h" ]; then
+             MCACHED_IPATH="$i"
+-        fi
+-        if [ -f "$i/libmemcached/memcached.h" ]; then
++        elif [ -f "$i/libmemcached/memcached.h" ]; then
+             MCACHED_IPATH="$i/libmemcached"
+-        fi
+-        if [ -f "$i/libmemcached-1.0/memcached.h" ]; then
++        elif [ -f "$i/libmemcached-1.0/memcached.h" ]; then
+             MCACHED_IPATH="$i/libmemcached-1.0"
+         fi
+     fi
diff -Nru hydra-9.2/debian/patches/series hydra-9.2/debian/patches/series
--- hydra-9.2/debian/patches/series     2021-11-12 17:52:58.000000000 -0700
+++ hydra-9.2/debian/patches/series     2022-01-31 14:02:53.000000000 -0700
@@ -5,3 +5,4 @@
 03_use_bin_path.diff
 06_show_xhydra_build_output.diff
 07_remove_troubled_files.diff
+10_memcached_include.diff

Reply via email to