Bug#1013102: cmd/link: check CGO_CFLAGS for non -g/-I/-O options before,+ internal linking

2022-06-23 Thread Shengjing Zhu
On Thu, Jun 23, 2022 at 9:27 PM Matthias Klose wrote: > > On 20.06.22 05:50, Michael Hudson-Doyle wrote: > > On Mon, 20 Jun 2022 at 14:59, Shengjing Zhu wrote: > >> diff --git a/lib/Debian/Debhelper/Buildsystem/golang.pm > >> b/lib/Debian/Debhelper/Buildsystem/golang.pm > >> index

Bug#1013102: cmd/link: check CGO_CFLAGS for non -g/-I/-O options before,+ internal linking

2022-06-23 Thread Matthias Klose
On 20.06.22 10:14, Shengjing Zhu wrote: On Mon, Jun 20, 2022 at 03:50:23PM +1200, Michael Hudson-Doyle wrote: On Mon, 20 Jun 2022 at 14:59, Shengjing Zhu wrote: On Mon, Jun 20, 2022 at 08:42:51AM +1200, Michael Hudson-Doyle wrote: Ah yes but that patch doesn't actually work in practice.

Bug#1013102: cmd/link: check CGO_CFLAGS for non -g/-I/-O options before,+ internal linking

2022-06-23 Thread Matthias Klose
On 20.06.22 05:50, Michael Hudson-Doyle wrote: On Mon, 20 Jun 2022 at 14:59, Shengjing Zhu wrote: On Mon, Jun 20, 2022 at 08:42:51AM +1200, Michael Hudson-Doyle wrote: Ah yes but that patch doesn't actually work in practice. I've been slack on this :( IIRC the problem with

Bug#1013102: cmd/link: check CGO_CFLAGS for non -g/-I/-O options before,+ internal linking

2022-06-20 Thread Shengjing Zhu
On Mon, Jun 20, 2022 at 03:50:23PM +1200, Michael Hudson-Doyle wrote: > On Mon, 20 Jun 2022 at 14:59, Shengjing Zhu wrote: > > > On Mon, Jun 20, 2022 at 08:42:51AM +1200, Michael Hudson-Doyle wrote: > > > Ah yes but that patch doesn't actually work in practice. I've been slack > > on > > > this

Bug#1013102: cmd/link: check CGO_CFLAGS for non -g/-I/-O options before,+ internal linking

2022-06-19 Thread Michael Hudson-Doyle
On Mon, 20 Jun 2022 at 14:59, Shengjing Zhu wrote: > On Mon, Jun 20, 2022 at 08:42:51AM +1200, Michael Hudson-Doyle wrote: > > Ah yes but that patch doesn't actually work in practice. I've been slack > on > > this :( > > > > IIRC the problem with https://go-review.googlesource.com/c/go/+/339370

Bug#1013102: cmd/link: check CGO_CFLAGS for non -g/-I/-O options before,+ internal linking

2022-06-19 Thread Shengjing Zhu
On Mon, Jun 20, 2022 at 08:42:51AM +1200, Michael Hudson-Doyle wrote: > Ah yes but that patch doesn't actually work in practice. I've been slack on > this :( > > IIRC the problem with https://go-review.googlesource.com/c/go/+/339370 is > that lto causes some of the references in the linked

Bug#1013102: cmd/link: check CGO_CFLAGS for non -g/-I/-O options before,+ internal linking

2022-06-19 Thread Michael Hudson-Doyle
Ah yes but that patch doesn't actually work in practice. I've been slack on this :( IIRC the problem with https://go-review.googlesource.com/c/go/+/339370 is that lto causes some of the references in the linked executable to disappear, meaning cgo can't do the analysis it needs to do. It's a

Bug#1013102: cmd/link: check CGO_CFLAGS for non -g/-I/-O options before,+ internal linking

2022-06-17 Thread Shengjing Zhu
On Fri, Jun 17, 2022 at 3:36 PM Matthias Klose wrote: > > Package: src:golang-1.18 > Version: 1.18.3-1 > Severity: wishlist > Tags: patch > > lto support now landed in dpkg in unstable, now evaluation the possibility to > turn on link time optimizations by default. Currently builds fail like: >

Bug#1013102: cmd/link: check CGO_CFLAGS for non -g/-I/-O options before,+ internal linking

2022-06-17 Thread Matthias Klose
Package: src:golang-1.18 Version: 1.18.3-1 Severity: wishlist Tags: patch lto support now landed in dpkg in unstable, now evaluation the possibility to turn on link time optimizations by default. Currently builds fail like: [...] loadelf: $WORK/b101/_pkg_.a(_x001.o): 151068: sym#11