Bug#1034236: mpd: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

2023-04-23 Thread Florian Schlichting
Control: severity ! important On Fri, Apr 21, 2023 at 03:24:25PM +0200, Geoffroy Youri Berret wrote: > Le 11/04/2023 à 23:52, Florian Schlichting a écrit : > > […] > > I think we should take a step back and think about how a freshly > > installed mpd package should look like. I think it may

Bug#1034236: mpd: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

2023-04-21 Thread Geoffroy Youri Berret
Le 11/04/2023 à 23:52, Florian Schlichting a écrit : […] I think we should take a step back and think about how a freshly installed mpd package should look like. I think it may actually be a feature that the system mpd.service is not enabled and started on a fresh install. On most

Bug#1034236: mpd: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

2023-04-11 Thread Florian Schlichting
I'm AFK this week so won't be able to do an upload either. I agree that putting the unit files where systemd.pc says they should go is probably the right thing to do. However it feels nonsensical to move files from /usr/lib to /lib only so they can be moved back by the /usr-merge; reading

Bug#1034236: mpd: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

2023-04-11 Thread Geoffroy Youri Berret
On 4/11/23 17:57, Max Kellermann wrote: On 2023/04/11 17:40, Andreas Henriksson wrote: I think 2 is better myself and I'm attaching a proof of concept debdiff to implement it. (You might want to make a cleaner version.) Agree. I think your patch looks quite clean, and if it were submitted

Bug#1034236: mpd: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

2023-04-11 Thread Max Kellermann
On 2023/04/11 17:40, Andreas Henriksson wrote: > I think 2 is better myself and I'm attaching a proof of concept > debdiff to implement it. (You might want to make a cleaner version.) Agree. I think your patch looks quite clean, and if it were submitted to me, I'd merge it (the same would

Bug#1034236: mpd: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

2023-04-11 Thread Andreas Henriksson
Hello Max Kellermann, On Tue, Apr 11, 2023 at 04:13:28PM +0200, Max Kellermann wrote: > On 2023/04/11 15:11, Andreas Henriksson wrote: > > The culprit seems to be that mpd falls back on hard-coded path (instead > > of failing) when systemd.pc is not found! > > What does this have to do with

Bug#1034236: mpd: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

2023-04-11 Thread Max Kellermann
On 2023/04/11 15:11, Andreas Henriksson wrote: > The culprit seems to be that mpd falls back on hard-coded path (instead > of failing) when systemd.pc is not found! What does this have to do with systemd.pc? It isn't used anywhere.

Bug#1034236: mpd: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

2023-04-11 Thread Andreas Henriksson
On Tue, Apr 11, 2023 at 09:37:27AM +0200, bi...@debian.org wrote: > Package: mpd > Version: 0.23.12-1 > Severity: serious > Tags: sid bookworm > User: debhel...@packages.debian.org > Usertags: systemd-files-in-usr-bookworm > > Dear Maintainer, > > It seems that your package mpd is shipping