Hi,
oops, forgot to replace submit with 1040...@bugs.debian.org. Forwarding.
Regards,
Rene
-------- Weitergeleitete Nachricht --------
Betreff: Re: API change in 8.0.0-1 (was: Re: Accepted harfbuzz 8.0.0-1
(source amd64 all) into unstable)
Datum: Tue, 11 Jul 2023 22:07:11 +0200
Von: Rene Engelhard <r...@debian.org>
Organisation: Debian Project
An: sub...@bugs.debian.org
Kopie (CC): 1035...@bugs.debian.org, James Addison <j...@jp-hosting.net>
Hi,
Am 11.07.23 um 21:38 schrieb Rene Engelhard:
[...] Because with that change you cause FTBFS in packages:
https://codesearch.debian.net/search?q=HB_LANGUAGE_INVALID&perpkg=1
While some of it are internal copies I see pango, freetype, libreoffice
etc.
libreoffice fails as of now with:
[...]
So a discussion on IRC turned out that this probably "only" is a problem
for C++, not C. Still it is a problem.
I'll do
diff --git a/vcl/source/font/PhysicalFontFace.cxx
b/vcl/source/font/PhysicalFontFace.cxx
index aa9a9327f708..a19b393be098 100644
--- a/vcl/source/font/PhysicalFontFace.cxx
+++ b/vcl/source/font/PhysicalFontFace.cxx
@@ -38,6 +38,13 @@
#include <hb-ot.h>
+#if HB_VERSION_ATLEAST(8, 0, 0) // Debian-only, see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1035669
+#if HB_LANGUAGE_INVALID == 0
+#undef HB_LANGUAGE_INVALID
+#define HB_LANGUAGE_INVALID ((hb_language_t) 0)
+#endif
+#endif
+
namespace vcl::font
{
PhysicalFontFace::PhysicalFontFace(const FontAttributes& rDFA)
in libreoffice for now (which should work in old and new harfbuzz), but...
Please revert.
... I still think that should be done.
Regards,
Rene