Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-11-07 Thread Sebastian Andrzej Siewior
control: tags -1 patch fixed-upstream On 2023-10-02 17:12:53 [+0200], Julian Andres Klode wrote: > Being subscribed to the mailing list, grabbing the patch and applying > it and shipping it isn't hard, but if you were wondering why it's There are different views here. But Daniel was nice enough

Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-11-01 Thread Paul Gevers
Hi all, Reading the thread starting at [1] it seems that upstream there's convergence on the patch? Can we move this bug forward in Debian too? Paul [1] https://lists.gnu.org/archive/html/grub-devel/2023-10/msg00150.html OpenPGP_signature.asc Description: OpenPGP digital signature

Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-10-02 Thread Jon DeVree
On Mon, Oct 02, 2023 at 16:51:30 +, Lidong Chen wrote: > The changes for the extent parsing looks good to me. But, I am not sure about > this change: > > > - if (filename + direntry->len - 1 > (char *) tail) > > + if (filename + direntry->len - 1 > (char *) end) > >

Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-10-02 Thread Lidong Chen
The changes for the extent parsing looks good to me. But, I am not sure about this change: > - if (filename + direntry->len - 1 > (char *) tail) > + if (filename + direntry->len - 1 > (char *) end) Looking at the grub_xfs_next_de(), should the ‘+1’ be ‘+3’?

Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-10-02 Thread Lidong Chen
On Oct 2, 2023, at 9:51 AM, lidong.c...@oracle.com wrote: The changes for the extent parsing looks good to me. But, I am not sure about this change: > - if (filename + direntry->len - 1 > (char *) tail) > + if (filename + direntry->len - 1 > (char *) end) Sorry, I

Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-10-02 Thread Julian Andres Klode
On Fri, Sep 29, 2023 at 10:36:03PM +0200, Sebastian Andrzej Siewior wrote: > On 2023-09-27 21:45:03 [-0400], Jon DeVree wrote: > > I posted an updated v3 version of the patch: > > > > https://lists.gnu.org/archive/html/grub-devel/2023-09/msg00110.html > > Just rebuilt grub with v3 of the patch

Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-09-29 Thread Sebastian Andrzej Siewior
On 2023-09-27 21:45:03 [-0400], Jon DeVree wrote: > I posted an updated v3 version of the patch: > > https://lists.gnu.org/archive/html/grub-devel/2023-09/msg00110.html Just rebuilt grub with v3 of the patch and I can confirm that it works. Thank you. Referencing the message-id or the link to

Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-09-27 Thread Jon DeVree
On Fri, Sep 15, 2023 at 23:43:28 +0200, Sebastian Andrzej Siewior wrote: > > there's now a patch from Jon DeVree upstream, which might fix this for > > you. Is it possible for you to test his patch? > > > > https://lists.gnu.org/archive/html/grub-devel/2023-09/msg00059.html > > Yes it sovles the

Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-09-15 Thread Sebastian Andrzej Siewior
On 2023-09-15 15:51:51 [+0200], Felix Zielcke wrote: > Hi Sebastian, Hi Felix, > there's now a patch from Jon DeVree upstream, which might fix this for > you. Is it possible for you to test his patch? > > https://lists.gnu.org/archive/html/grub-devel/2023-09/msg00059.html Yes it sovles the

Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-09-15 Thread Felix Zielcke
Am Samstag, dem 09.09.2023 um 15:41 +0200 schrieb Sebastian Andrzej Siewior: > Package: grub2 > Version: 2.12~rc1-9 > Severity: Serious > control: forwarded -1 https://savannah.gnu.org/bugs/?64376 > > I have a single XFS partition which contains the root filesystem and > the > boot partition.

Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-09-12 Thread Jamie Heilman
Funny, I had this problem (unbootable system, couldn't find net.mod even though it was there ls on the grub_rescue prompt didn't see it) with a XFS V4 partition, and rebuilding that as V5 and copying everything over seemed to have fixed it... but maybe I just got lucky on the first try.

Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-09-12 Thread Sebastian Andrzej Siewior
On 2023-09-12 15:43:34 [+0200], Daniel Kiper wrote: > Hey, Hi, > Adding Lidong... > > Sebastian, Lidong is working on a fix for this issue. ach great. > Lidong, please keep Sebastain in the loop. > > Daniel Sebastian

Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-09-12 Thread Daniel Kiper
Hey, Adding Lidong... Sebastian, Lidong is working on a fix for this issue. Lidong, please keep Sebastain in the loop. Daniel On Sat, Sep 09, 2023 at 03:41:55PM +0200, Sebastian Andrzej Siewior wrote: > Package: grub2 > Version: 2.12~rc1-9 > Severity: Serious > control: forwarded -1

Bug#1051543: grub2: Fails to load normal.mod from a XFS v5 parition.

2023-09-09 Thread Sebastian Andrzej Siewior
Package: grub2 Version: 2.12~rc1-9 Severity: Serious control: forwarded -1 https://savannah.gnu.org/bugs/?64376 I have a single XFS partition which contains the root filesystem and the boot partition. Since the recent upgrade to the 2.12 series I can't boot anymore because grub complains that it