Bug#1067651: mapserver fails to build on armhf in Ubuntu due to implicit declaration of strlcpy

2024-05-08 Thread Santiago Vila
severity 1067651 serious retitle 1067651 mapserver: FTBFS: error: implicit declaration of function ‘strlcpy’ thanks El 25/3/24 a las 9:25, Vladimir Petko escribió: strlcpy and strlcat were introduced in glibc 2.38[1]. At the moment Ubuntu noble has 2.39 and Debian unstable - 2.37. The

Bug#1067651: mapserver fails to build on armhf in Ubuntu due to implicit declaration of strlcpy

2024-03-25 Thread Sebastiaan Couwenberg
Control: tags -1 pending On 3/25/24 10:20 AM, Vladimir Petko wrote: I've made a small change to the patch: used -D_DEFAULT_SOURCE[1] to avoid the deprecation warning. I have tested noble and sid build with the attached patch. Thanks for you patch improvements. I've managed to test my original

Bug#1067651: mapserver fails to build on armhf in Ubuntu due to implicit declaration of strlcpy

2024-03-25 Thread Vladimir Petko
Hi, Thank you!!! I've made a small change to the patch: used -D_DEFAULT_SOURCE[1] to avoid the deprecation warning. I have tested noble and sid build with the attached patch. Best Regards, Vladimir. [1] https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html On Mon, Mar

Bug#1067651: mapserver fails to build on armhf in Ubuntu due to implicit declaration of strlcpy

2024-03-25 Thread Sebastiaan Couwenberg
On 3/25/24 9:25 AM, Vladimir Petko wrote: strlcpy and strlcat were introduced in glibc 2.38[1]. At the moment Ubuntu noble has 2.39 and Debian unstable - 2.37. Can you try the attached patch which patches CMakeLists.txt to add the definition when strlcat/strlcpy are found on Linux? Kind

Bug#1067651: mapserver fails to build on armhf in Ubuntu due to implicit declaration of strlcpy

2024-03-25 Thread Vladimir Petko
Hi, strlcpy and strlcat were introduced in glibc 2.38[1]. At the moment Ubuntu noble has 2.39 and Debian unstable - 2.37. The issue will become relevant for Debian once glibc 2.38 is introduced to unstable. Best Regards, Vladimir. [1]

Bug#1067651: mapserver fails to build on armhf in Ubuntu due to implicit declaration of strlcpy

2024-03-25 Thread Sebastiaan Couwenberg
On 3/25/24 6:31 AM, Vladimir Petko wrote: The CMake checks if the function is present in the runtime library (whether strlcpy() compiles), but the declaration in string.h itself is guarded by __USE_MISC define. On armhf in Ubuntu toolchain has -Werror=implicit-function-declaration flag that

Bug#1067651: mapserver fails to build on armhf in Ubuntu due to implicit declaration of strlcpy

2024-03-24 Thread Vladimir Petko
Hi, The CMake checks if the function is present in the runtime library (whether strlcpy() compiles), but the declaration in string.h itself is guarded by __USE_MISC define. On armhf in Ubuntu toolchain has -Werror=implicit-function-declaration flag that causes the build failure. Best Regards,

Bug#1067651: mapserver fails to build on armhf in Ubuntu due to implicit declaration of strlcpy

2024-03-24 Thread Sebastiaan Couwenberg
Control: tags -1 upstream moreinfo On 3/25/24 3:39 AM, Vladimir Petko wrote: In Ubuntu, the attached patch was applied to achieve the following: * d/rules: define -D_BSD_SOURCE to ensure that strlcpy/strlcat functions are declared (LP: #2058864). That seems wrong. CMakeLists.txt

Bug#1067651: mapserver fails to build on armhf in Ubuntu due to implicit declaration of strlcpy

2024-03-24 Thread Vladimir Petko
Package: mapserver Severity: wishlist Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu noble ubuntu-patch Dear Maintainer, The package failed to build in Ubuntu noble on armhf: -- /<>/mapshape.c: In function ‘msShapefileOpenHandle’: /<>/mapshape.c:1755:3: error: implicit