Source: goldendict-ng
Version: 23.12.26-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timezone
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed that
goldendict-ng could not be built reproducibly.
This is because it does not specify the "UTC" argument to CMake's
TIMESTAMP macro function, so the build time embedded in the final
binary, whilst based on SOURCE_DATE_EPOCH, varies by the build
timezone.
Patch attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
--- a/debian/patches/0002-Reproducible-build.patch 1970-01-01
01:00:00.000000000 +0100
--- b/debian/patches/0002-Reproducible-build.patch 2024-04-01
11:02:36.411764040 +0100
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <la...@debian.org>
+Last-Update: 2024-04-01
+
+--- goldendict-ng-23.12.26.orig/CMakeLists.txt
++++ goldendict-ng-23.12.26/CMakeLists.txt
+@@ -54,7 +54,7 @@ set(CMAKE_AUTORCC ON) # not included in
+ #### Things required during configuration
+
+ block() # generate version.txt
+- string(TIMESTAMP build_time)
++ string(TIMESTAMP build_time UTC)
+ find_package(Git)
+ if (EXISTS "${CMAKE_SOURCE_DIR}/.git" AND GIT_FOUND)
+ execute_process(
--- a/debian/patches/series 2024-04-01 09:53:57.209332464 +0100
--- b/debian/patches/series 2024-04-01 11:02:35.515760642 +0100
@@ -1 +1,2 @@
0001-Disable-checkUpdate-by-default.patch
+0002-Reproducible-build.patch
