Could you use either a git formatted patch or a Salsa merge request
for further iterations of this submission? I believe
debian/tests/compile-and-execute should be marked as executable since
it's a shell script but that information is not encoded in your diff
file.
I believe it is more convenient
Swapping the order of definition of the arrays as in this updated patch fixes
the stack smashing with the stack protector enabled — which is ideal so if you
still didn't upload the previous one, prefer this one —, maybe a bug in GCC[1].
Hopefully that will help aarch64 otherwise let's just try Cla
Thanks for the warning. The attached patch will make it fail the tests if
pkg-config fails.
I also extended the inline C program to print the result array vs. the expected
array in case it returns non-zero, as I see it did fail on aarch64. Not that it
helps much but at least it is explicit.
--- hi
The autopkgtest prints a warning that pkg-config cannot be found. The
test then passes on all architectures.
We can add pkgconf to the autopkgtest Depends, but I believe that a
failure in the pkg-config step ought to fail the test.
https://autopkgtest.ubuntu.com/packages/highway
Thank you,
Jerem
I'm not the Debian maintainer for highway, but here's a suggestion:
-Depends: @, g++
+Depends: libhwy-dev, g++
since the point of this is to test that libhwy-dev works and has its
Depends set correctly.
I have uploaded your patch with my suggested change to Ubuntu since we
need an autopkgtest li
Source: highway
Version: 1.2.0-2
Severity: normal
Tags: patch
X-Debbugs-Cc: nathan.teodo...@canonical.com
Dear Maintainer,
I'm proposing adding a simple autopkgtest.
Cheers,
Nathan Teodosio
6 matches
Mail list logo
