Bug#162291: Bug in executable completion: unable to handle .. it $PATH

2009-01-07 Thread Richard Hartmann
On Wed, Jan 7, 2009 at 21:49, Peter Stephenson wrote: > Since the path is still absolute I don't see how this could effect > security, either, except maybe at second hand... if you sanitized the > early part of the path but didn't look for "..", so the component could > end up pointing out of tha

Bug#162291: Bug in executable completion: unable to handle .. it $PATH

2009-01-07 Thread Peter Stephenson
Bart Schaefer wrote: > On Jan 7, 8:09pm, Peter Stephenson wrote: > } > } This is done explicitly in the code, but I have no idea why; it precedes > } the CVS archive. The function isrelative() is only used by hashdir(). > > I believe it's a security thing, so that an inherited $PATH can't fool >

Bug#162291: Bug in executable completion: unable to handle .. it $PATH

2009-01-07 Thread Bart Schaefer
On Jan 7, 8:09pm, Peter Stephenson wrote: } } This is done explicitly in the code, but I have no idea why; it precedes } the CVS archive. The function isrelative() is only used by hashdir(). I believe it's a security thing, so that an inherited $PATH can't fool someone into executing code from a

Bug#162291: Bug in executable completion: unable to handle .. it $PATH

2009-01-01 Thread Vincent Lefevre
On 2009-01-01 17:24:17 +0100, Richard Hartmann wrote: > roadwarrior% touch foobin > roadwarrior% chmod +x foobin > roadwarrior% export PATH=/home/richih/killme > roadwarrior% fo > foofoobin forforeach > roadwarrior% export PATH=/home/richih/../richih/killme > roadwarrior% fo > r

Bug#162291: Bug in executable completion: unable to handle .. it $PATH

2009-01-01 Thread Richard Hartmann
Hi all, don't ask me why anyone would use .. in $PATH, but here goes: roadwarrior% touch foobin roadwarrior% chmod +x foobin roadwarrior% export PATH=/home/richih/killme roadwarrior% fo foofoobin forforeach roadwarrior% export PATH=/home/richih/../richih/killme roadwarrior% fo