Hi James, 

On Thu, Apr 14, 2005 at 11:16:58PM -0400, James Clendenan wrote:
 
> Found 2 errors in the update/upgrade script that render the update
> process unuseable for some users.
> 
> 1.  The new Slapd 2.2 parser seems to dislike a line like this:
> 
> "loglevel 256 ### this is a inline comment"
> 
>     The old version didn't seem to care, this one does, if you can just
>     line break right after/before lines like this if possible (yes this
>     will cause problems with multi line ACL's)

Hmm, normally a comment should start in the first column of a line.
AFAIK end-of-line commends are not allowed (checked the config parser
for 2.1, I'll look into the current parser to verify). 

> 2.  ACL rewriting.
>       First off, thanks very much for doing much of this work, saved
>       me a huge headache rewriting some of my rules.
>       However:  if you have 2 acl lines as such:
> 
>       access to .....
>               by dn.subtree.....
>               by dn.one......
>       
>       access to ....another ...
>               by dn.subtree....
>               by dn.one.....
> 
>       the rewriter throws a nice fit, and rewrites them as one really
>       long line.  Which the parser has absolutely no idea how to
>       parse, and doesn't load the new database when trying to slapadd
>       the backed up ldif file.

Very interesting. Thanks for finding out!

>       Adding a pair of ##'s between the line however seemed to work
>       fine.  It feels like you missed a new line as a new empty line
>       rule as a delimiter for the ACL parser.

Probably some spaces are on the empty line, the parser joins lines
starting with spaces. Probably the line has to be stripped first.

> Thanks again, and keep up the wonderful work.

Thanks for your feedback!

Greetings

        Torsten

Attachment: signature.asc
Description: Digital signature

Reply via email to