After constructing a regression testsuite to test the problem,
I'm more inclined to go into a '1' option with a check.
If dpatch-edit-patch is invoked with a patch name that is
already found in debian/patched/ dir,
abort if --clean is not specified.
This has been pending for a
Hi,
Two options here:
1. force the edited patch to be 'unpatched' before dpep invocation
- a less pleasant experience to those who are used to the current
behavior,
but it's broken anyway?
2. store the original patch in debian/patched/ and use that for unpatching
-
Hi,
If dpatch-edit-patch is invoked with a patch name that is
already found in debian/patched/ dir,
abort if --clean is not specified.
Good idea.
${stampdir} is a configurable directory with dpatch,
and dpatch-edit-patch does not know about it.
I propose to
1. remove or deprecate
Hi,
Two options here:
1. force the edited patch to be 'unpatched' before dpep invocation
- a less pleasant experience to those who are used to the current behavior,
but it's broken anyway?
2. store the original patch in debian/patched/ and use that for unpatching
- this will be
On Tue, Jun 21, 2005 at 08:38:54AM +0900, Junichi Uekawa wrote:
If dpatch-edit-patch is invoked with a patch name that is
already found in debian/patched/ dir,
abort if --clean is not specified.
Good idea.
Greetings
Marc
--
On Fri, Jun 17, 2005 at 09:14:49AM +0900, Junichi Uekawa wrote:
2. store the original patch in debian/patched/ and use that for unpatching
- this will be an incompatible change which may break more.
So your suggestion is the following:
- on dpatch_patch_apply, after applying the patch, copy
Hi,
On Fri, Jun 17, 2005 at 09:14:49AM +0900, Junichi Uekawa wrote:
2. store the original patch in debian/patched/ and use that for unpatching
- this will be an incompatible change which may break more.
So your suggestion is the following:
- on dpatch_patch_apply, after applying the
On Sat, Jun 18, 2005 at 09:01:56PM +0900, Junichi Uekawa wrote:
I think no.1 is the more feasible option.
So --clean should be the default? Or do you suggest to back out only
the to-be-edited patch in dpep? How do we handle failures of doing so?
Greetings
Marc
--
I think no.1 is the more feasible option.
So --clean should be the default? Or do you suggest to back out only
the to-be-edited patch in dpep? How do we handle failures of doing so?
Yeah, I think the feature of not cleaning the source dir before
copying is not working quite as intended.
On Sat, Jun 18, 2005 at 10:52:59PM +0900, Junichi Uekawa wrote:
I think no.1 is the more feasible option.
So --clean should be the default? Or do you suggest to back out only
the to-be-edited patch in dpep? How do we handle failures of doing so?
Yeah, I think the feature of not
I think no.1 is the more feasible option.
So --clean should be the default? Or do you suggest to back out only
the to-be-edited patch in dpep? How do we handle failures of doing so?
Yeah, I think the feature of not cleaning the source dir before
copying is not working quite
Am Freitag, den 17.06.2005, 09:14 +0900 schrieb Junichi Uekawa:
Hi,
dpatch tries to revert the changes made
by /home/user/package_source-a.b/debian/patches/01_patch_1.dpatch and
this fails, because this is the updated patch, which was never applied
to /home/user/package_source-a.b - the
Package: dpatch
Version: 2.0.13
Severity: normal
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Ok, I try to explain the situation:
Let's say, we are working in the source tree of a Debian package and ran
build target, so the patch/patch-stamp target was called. The source is
now patched. Now
On Thu, Jun 16, 2005 at 06:46:04PM +0200, Daniel Leidert wrote:
Let's say, we are working in the source tree of a Debian package and ran
build target, so the patch/patch-stamp target was called. The source is
now patched. Now you maybe see a mistake and you want to edit an
existing patch.
Marc Haber wrote:
On Thu, Jun 16, 2005 at 06:46:04PM +0200, Daniel Leidert wrote:
Let's say, we are working in the source tree of a Debian package and ran
build target, so the patch/patch-stamp target was called. The source is
now patched. Now you maybe see a mistake and you want to edit
Hi,
dpatch tries to revert the changes made
by /home/user/package_source-a.b/debian/patches/01_patch_1.dpatch and
this fails, because this is the updated patch, which was never applied
to /home/user/package_source-a.b - the old version of 01_patch_1.dpatch
is still applied to your working
16 matches
Mail list logo
