Package: cvs
Version: 1:1.12.9-15
Followup-For: Bug #329127

Hi,

The bug is not compiler-related. By checking some of the compiler
warnings I found two bugs where cvs mixes 32-bit and 64-bit data types.
I think it was pure chance that cvs worked on any 64-bit architecture
so far. Patch is below; the second hunk fixes the crash in the original
bugreport (the first hunk is also a real bugfix).

Gabor

diff -u -r cvs-1.12.9.orig/diff/util.c cvs-1.12.9/diff/util.c
--- cvs-1.12.9.orig/diff/util.c 2003-02-02 20:52:38.000000000 +0100
+++ cvs-1.12.9/diff/util.c      2005-10-20 10:35:01.000000000 +0200
@@ -235,7 +235,7 @@
              close (pipes[0]);
            }
 
-         execl (PR_PROGRAM, PR_PROGRAM, "-f", "-h", name, 0);
+         execl (PR_PROGRAM, PR_PROGRAM, "-f", "-h", name, (char *)NULL);
          pfatal_with_name (PR_PROGRAM);
        }
       else
diff -u -r cvs-1.12.9.orig/src/vers_ts.c cvs-1.12.9/src/vers_ts.c
--- cvs-1.12.9.orig/src/vers_ts.c       2004-05-20 05:00:44.000000000 +0200
+++ cvs-1.12.9/src/vers_ts.c    2005-10-20 10:43:29.000000000 +0200
@@ -355,7 +355,7 @@
 {
     struct tm *tm_p;
     char *cp;
-    int length;
+    size_t length;
 
     /* We want to use the same timestamp format as is stored in the
        st_mtime.  For unix (and NT I think) this *must* be universal


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to