Bug#375076: suggestion for a workaround

2006-07-11 Thread Daniel Stenberg
On Mon, 10 Jul 2006, Harald Dunkel wrote: Indeed, but you instead added a memory-leak. And I truly don't think this work-around is good enough to actually hide the problems for you properly... How many entries would you usually expect for the splay tree? I doubt that the memory leak is a ser

Bug#375076: suggestion for a workaround

2006-07-09 Thread Harald Dunkel
Hi Daniel, Daniel Stenberg wrote: > On Sun, 9 Jul 2006, Harald Dunkel wrote: > >> My testcase did not crash anymore, but of course the problem is not >> _that_ much reproducable. > > Indeed, but you instead added a memory-leak. And I truly don't think > this work-around is good enough to actuall

Bug#375076: suggestion for a workaround

2006-07-09 Thread Daniel Stenberg
On Sun, 9 Jul 2006, Harald Dunkel wrote: If it is allowed, then I would suggest to copy the node in Curl_splayinsert to make sure that memory doesn't get out of scope in a calling function. See the attached patch. Thanks for your work. My testcase did not crash anymore, but of course the pro

Bug#375076: suggestion for a workaround

2006-07-09 Thread Harald Dunkel
Tags: patch Hi Daniel, If it is allowed, then I would suggest to copy the node in Curl_splayinsert to make sure that memory doesn't get out of scope in a calling function. See the attached patch. My testcase did not crash anymore, but of course the problem is not _that_ much reproducable. Since