Bug#386197: dpkg: strtol checks don't fail when given a null string

2009-03-23 Thread Raphael Hertzog
On Mon, 23 Mar 2009, Guillem Jover wrote: You added an unwanted * in the check. I'll commit it soon after tests. Before closing this bug, I'd like to get all other instances of strto* in the source tree reviewed, for this kind of missing checks or other flacky usage. Fortunately there

Bug#386197: dpkg: strtol checks don't fail when given a null string

2009-03-22 Thread Raphael Hertzog
On Fri, 20 Mar 2009, Bill Allombert wrote: This is easy to fix by checking (s==end), or by setting errno=0 before calling strto* functions, and checking (errno!=0) afterwards (see the recently-updated manpage example). Given enough time, I will eventually provide a patch for this, but I

Bug#386197: dpkg: strtol checks don't fail when given a null string

2009-03-22 Thread Guillem Jover
Hi! On Sun, 2009-03-22 at 13:23:45 +0100, Raphael Hertzog wrote: On Fri, 20 Mar 2009, Bill Allombert wrote: This is easy to fix by checking (s==end), or by setting errno=0 before calling strto* functions, and checking (errno!=0) afterwards (see the recently-updated manpage example).

Bug#386197: dpkg: strtol checks don't fail when given a null string

2009-03-20 Thread Bill Allombert
tags 386197 patch quit On Tue, Sep 05, 2006 at 03:30:56PM -0400, Justin Pryzby wrote: Package: dpkg Version: 1.13.21 Severity: normal $ sudo dpkg --abort-after '' -i / dpkg-split: error reading /: Is a directory dpkg: error processing / (--install): subprocess dpkg-split returned error

Bug#386197: dpkg: strtol checks don't fail when given a null string

2006-09-05 Thread Justin Pryzby
Package: dpkg Version: 1.13.21 Severity: normal $ sudo dpkg --abort-after '' -i / dpkg-split: error reading /: Is a directory dpkg: error processing / (--install): subprocess dpkg-split returned error exit status 2 dpkg: too many errors, stopping Errors were encountered while processing: /