Package: live-package
Version: 0.99.6-1
Tags: patch

The make-live script cannot handle spaces in arguments.  For example, if one
tries
make-live --packages "vim emacs"
only vim is installed, not emacs.  It's even worse when there are options
inside the argument:
make-live --hook "dpkg --install foo.deb"
results in "unknown option --install" (from make-live, which shouldn't parse
that option).

The reason is a set of missing quotes on line 161.  That now reads:

ARGUMENTS="`getopt --longoptions 
root:,type:,architecture:,bootappend:,config:,chroot:,distribution:,filesystem:,flavour:,hook:,include-chroot:,include-image:,kernel:,manifest:,mirror:,mirror-security:,output:,packages:,package-list:,proxy-ftp:,proxy-http:,section:,server-address:,server-path:,templates:,with-generic-indices,without-generic-indices,with-source,without-source,help,usage,version
 --name=${PROGRAM} --options r:t:a:b:c:d:f:k:m:o:p:s:huv --shell sh -- [EMAIL 
PROTECTED]"

The [EMAIL PROTECTED] at the end needs double quotes around it to prevent 
argument
splitting.  It then becomes:

ARGUMENTS="`getopt --longoptions 
root:,type:,architecture:,bootappend:,config:,chroot:,distribution:,filesystem:,flavour:,hook:,include-chroot:,include-image:,kernel:,manifest:,mirror:,mirror-security:,output:,packages:,package-list:,proxy-ftp:,proxy-http:,section:,server-address:,server-path:,templates:,with-generic-indices,without-generic-indices,with-source,without-source,help,usage,version
 --name=${PROGRAM} --options r:t:a:b:c:d:f:k:m:o:p:s:huv --shell sh -- "[EMAIL 
PROTECTED]"`"

Thanks,
Bas Wijnen

-- 
I encourage people to send encrypted e-mail (see http://www.gnupg.org).
If you have problems reading my e-mail, use a better reader.
Please send the central message of e-mails as plain text
   in the message body, not as HTML and definitely not as MS Word.
Please do not use the MS Word format for attachments either.
For more information, see http://129.125.47.90/e-mail.html

Attachment: signature.asc
Description: Digital signature

Reply via email to