On Mar 28, Aníbal Monsalve Salazar ani...@debian.org wrote:
On Sat, Mar 28, 2009 at 02:52:25PM +1100, Anibal Monsalve Salazar wrote:
On Sat, Mar 28, 2009 at 04:22:39AM +0100, Marco d'Itri wrote:
+# define pcre_compile dl_pcre_compile
+# define pcre_study dl_pcre_study
+# define pcre_exec
On Wed, Mar 25, 2009 at 11:46:50PM +, Reuben Thomas wrote:
To get it to build I removed the --disable-perl-regexp from the
configure line in debian/rules, and added -dl to the end of LDFLAGS.
The installed package seems to work, in particular the -P option.
Do you have libpcre3-dev installed
On Fri, 27 Mar 2009, Aníbal Monsalve Salazar wrote:
On Wed, Mar 25, 2009 at 11:46:50PM +, Reuben Thomas wrote:
To get it to build I removed the --disable-perl-regexp from the
configure line in debian/rules, and added -dl to the end of LDFLAGS.
The installed package seems to work, in
On Mar 27, Aníbal Monsalve Salazar ani...@debian.org wrote:
The file attached is based on your patch.
Removing the HAVE_LIBPCRE ifdefs looks wrong and unmaintenable, you
should just unconditionally define it.
--
ciao,
Marco
signature.asc
Description: Digital signature
On Mar 27, Reuben Thomas r...@sc3d.org wrote:
Yes. I understand your patch to configure, but I don't understand why you
can't still have libpcre3-dev as a build-dep, and avoid copying lots of
its header file into the patch.
Indeed, the correct way is to keep using libpcre3-dev.
--
ciao,
Also, it looks as though with the patch you'll build without
--disable-perl-regexp? That would be good, as it would mean that Ubuntu, who
have libpcre in /lib and hence already ship with PCRE support, would be able
simply to ignore this patch; effectively this would be a patch for getting
On Fri, Mar 27, 2009 at 01:15:16PM +, Reuben Thomas wrote:
Also, it looks as though with the patch you'll build without
--disable-perl-regexp? That would be good, as it would mean that Ubuntu,
who have libpcre in /lib and hence already ship with PCRE support, would
be able simply to ignore
On Fri, Mar 27, 2009 at 02:05:25PM +0100, Marco d'Itri wrote:
On Mar 27, Aníbal Monsalve Salazar ani...@debian.org wrote:
The file attached is based on your patch.
Removing the HAVE_LIBPCRE ifdefs looks wrong and unmaintenable, you
should just unconditionally define it.
I'll look into that and
On Sat, Mar 28, 2009 at 12:38:54AM +1100, Anibal Monsalve Salazar wrote:
On Fri, Mar 27, 2009 at 02:05:25PM +0100, Marco d'Itri wrote:
On Mar 27, Aníbal Monsalve Salazar ani...@debian.org wrote:
The file attached is based on your patch.
Removing the HAVE_LIBPCRE ifdefs looks wrong and
I am attaching a cleaned up patch for possible submission upstream.
My changes:
- introduced a HAVE_DYNAMIC_LIBPCRE macro which can be used to cleanly
enable or disable the feature and used #defines to reduce the scope of
changes
- no reason to use library_mapped, the function pointers are
On Sat, Mar 28, 2009 at 04:22:39AM +0100, Marco d'Itri wrote:
+# define pcre_compile dl_pcre_compile
+# define pcre_study dl_pcre_study
+# define pcre_exec dl_pcre_exec
+# define pcre_maketables dl_pcre_maketables
You don't need the defines above.
signature.asc
Description: Digital signature
On Sat, Mar 28, 2009 at 02:52:25PM +1100, Anibal Monsalve Salazar wrote:
On Sat, Mar 28, 2009 at 04:22:39AM +0100, Marco d'Itri wrote:
+# define pcre_compile dl_pcre_compile
+# define pcre_study dl_pcre_study
+# define pcre_exec dl_pcre_exec
+# define pcre_maketables dl_pcre_maketables
You don't
Hi,
I'm trying it, and it seems to do the job :)
I'll put the changes in the git repository. I think that it would be
good to upload it to experimental first, just in case.
Thanks a lot!,
On Wed, Mar 25, 2009 at 11:46:50PM +, Reuben Thomas wrote:
Hi,
To get it to build I removed the
On Wed, 25 Mar 2009, Aníbal Monsalve Salazar wrote:
On Tue, Mar 24, 2009 at 11:51:35PM +, Reuben Thomas wrote:
To clarify: my patch applies cleanly to current CVS.
Ah, but the one in the BTS appears to be out of date.
I attach the patch I have.
I tried it:
[errors]
OK, I'll have a
Hi,
To get it to build I removed the --disable-perl-regexp from the configure
line in debian/rules, and added -dl to the end of LDFLAGS. The installed
package seems to work, in particular the -P option.
--
http://rrt.sc3d.org/ | dumb blonde, n. susbt. phr. peroxymoron
--
To UNSUBSCRIBE,
On Nov 06, Reuben Thomas r...@sc3d.org wrote:
As we discussed a while ago, I've made a patch for grep to use PCRE
via dlopen.
Are there any news about this bug? Do you need help?
--
ciao,
Marco
signature.asc
Description: Digital signature
On Tue, Mar 24, 2009 at 10:12:03PM +0100, Marco d'Itri wrote:
On Nov 06, Reuben Thomas r...@sc3d.org wrote:
As we discussed a while ago, I've made a patch for grep to use PCRE
via dlopen.
Are there any news about this bug? Do you need help?
I'll see if the patch works with grep 2.5.4. The patch
On Wed, 25 Mar 2009, Aníbal Monsalve Salazar wrote:
On Tue, Mar 24, 2009 at 10:12:03PM +0100, Marco d'Itri wrote:
On Nov 06, Reuben Thomas r...@sc3d.org wrote:
As we discussed a while ago, I've made a patch for grep to use PCRE
via dlopen.
Are there any news about this bug? Do you need
On Tue, Mar 24, 2009 at 09:35:07PM +, Reuben Thomas wrote:
If there's interest, I'm happy to get it up to date.
Yes, please.
Upstream doesn't seem to have had time for it in the past couple of
years, though they're interested in principle too.
--
To UNSUBSCRIBE, email to
On Wed, 25 Mar 2009, Aníbal Monsalve Salazar wrote:
On Tue, Mar 24, 2009 at 09:35:07PM +, Reuben Thomas wrote:
If there's interest, I'm happy to get it up to date.
Yes, please.
Currently my patch applies cleanly. It only patches search.c, it doesn't
attempt to patch the build system;
To clarify: my patch applies cleanly to current CVS.
Ah, but the one in the BTS appears to be out of date.
I attach the patch I have.Binary files grep/src/egrep and grep-dlopen-pcre/src/egrep differ
Binary files grep/src/egrep.o and grep-dlopen-pcre/src/egrep.o differ
Binary files
On Tue, Mar 24, 2009 at 11:51:35PM +, Reuben Thomas wrote:
To clarify: my patch applies cleanly to current CVS.
Ah, but the one in the BTS appears to be out of date.
I attach the patch I have.
I tried it:
gcc -DHAVE_CONFIG_H -I. -I.. -I../intl -I../lib
-DLOCALEDIR=\/usr/share/locale\
On Fri, 10 Nov 2006, Santiago José Ruano Rincón wrote:
Thanks a lot,
I'll build a package with it as soon as possible.
Is there some problem with my patch? I see there's still a bug open on this
issue, which it would be nice to resolve.
--
http://rrt.sc3d.org/ | art, n. romanticized
On Wed, 18 Jul 2007, Reuben Thomas wrote:
On Fri, 10 Nov 2006, Santiago José Ruano Rincón wrote:
Thanks a lot,
I'll build a package with it as soon as possible.
Is there some problem with my patch? I see there's still a bug open on this
issue, which it would be nice to resolve.
I notice
Thanks a lot,
I'll build a package with it as soon as possible.
Kind regards,
Santiago
signature.asc
Description: Esta parte del mensaje está firmada digitalmente
Package: grep
Version: 2.5.1.ds2-5
Severity: wishlist
Tags: patch
As we discussed a while ago, I've made a patch for grep to use PCRE
via dlopen.
I'm afraid that I could not adequately beat the horrors of autotools
into submission, so my patch doesn't deal with linking or configuring.
I also
26 matches
Mail list logo
