Bug#439535: git-buildpackage: git-pbuilder should use $@, not $*

2007-08-28 Thread Jari Aalto
Guido Guenther [EMAIL PROTECTED] writes: git-pdebuild [debbuildopts] [pbuilderopts] git-buildpackage -uc -us You'd have to use git-buildpackage -uc -us. So you can't switch the builder (e.g. with and without pbuilder) without changeing the commandline, which is bad for scripts - what

Bug#439535: git-buildpackage: git-pbuilder should use $@, not $*

2007-08-26 Thread Guido Guenther
On Sun, Aug 26, 2007 at 12:18:02AM +0300, Jari Aalto wrote: Safer in a way that $@ doesn't care about IFS or in what way? -- Guido I was more thinking about the proper quoting. --buildsourceroot My Tempdir --debsign-k Mr Foo ... I'm curious, how would there be problem with

Bug#439535: git-buildpackage: git-pbuilder should use $@, not $*

2007-08-26 Thread Jari Aalto
Guido Guenther [EMAIL PROTECTED] writes: On Sun, Aug 26, 2007 at 12:18:02AM +0300, Jari Aalto wrote: Safer in a way that $@ doesn't care about IFS or in what way? -- Guido I was more thinking about the proper quoting. --buildsourceroot My Tempdir --debsign-k Mr Foo ... I'm

Bug#439535: git-buildpackage: git-pbuilder should use $@, not $*

2007-08-26 Thread Guido Guenther
Hi, On Sun, Aug 26, 2007 at 06:08:27PM +0300, Jari Aalto wrote: I use --buildresult and that wasn't possible with current $* Now I see, you're looking for a way to pass options on to _pbuilder_. The current git-pbuilder is _supposed_ to pass all options on to --debbuildoptions and none to

Bug#439535: git-buildpackage: git-pbuilder should use $@, not $*

2007-08-26 Thread Jari Aalto
Guido Guenther [EMAIL PROTECTED] writes: Hi, On Sun, Aug 26, 2007 at 06:08:27PM +0300, Jari Aalto wrote: I use --buildresult and that wasn't possible with current $* Now I see, you're looking for a way to pass options on to _pbuilder_. The current git-pbuilder is _supposed_ to pass

Bug#439535: git-buildpackage: git-pbuilder should use $@, not $*

2007-08-26 Thread Guido Guenther
On Mon, Aug 27, 2007 at 01:04:35AM +0300, Jari Aalto wrote: Guido Guenther [EMAIL PROTECTED] writes: Hi, On Sun, Aug 26, 2007 at 06:08:27PM +0300, Jari Aalto wrote: I use --buildresult and that wasn't possible with current $* Now I see, you're looking for a way to pass options

Bug#439535: git-buildpackage: git-pbuilder should use $@, not $*

2007-08-25 Thread Jari Aalto
Package: git-buildpackage Version: 0.3.3 Severity: minor Instead of this: pdebuild --debbuildopts $* Use this, for safer command line handling: pdebuild --debbuildopts $@ -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable') Architecture:

Bug#439535: git-buildpackage: git-pbuilder should use $@, not $*

2007-08-25 Thread Guido Guenther
On Sat, Aug 25, 2007 at 04:13:50PM +0300, Jari Aalto wrote: Package: git-buildpackage Version: 0.3.3 Severity: minor Instead of this: pdebuild --debbuildopts $* Use this, for safer command line handling: pdebuild --debbuildopts $@ Safer in a way that $@ doesn't care about IFS or

Bug#439535: git-buildpackage: git-pbuilder should use $@, not $*

2007-08-25 Thread Jari Aalto
Guido Guenther [EMAIL PROTECTED] writes: On Sat, Aug 25, 2007 at 04:13:50PM +0300, Jari Aalto wrote: Package: git-buildpackage Version: 0.3.3 Severity: minor Instead of this: pdebuild --debbuildopts $* Use this, for safer command line handling: pdebuild --debbuildopts $@