On Fri, 11 Jul 2008, Skywing wrote:
: All of the key confirmation prompts suffer from this flaw. I've got a
: fix for /getkey being broken, other than the lack of reference counting
: for the SilcClient and SilcClientConnection objects. There is nothing
: that can really be done about the
This sounds reasonable enough (still has the problem where we can't safely
unload the .so containing the callback, but don't think that is realistically
getting fixed at this point).
I'll see about providing you with a patch that fixes this using the suggested
method + does the additional work
Just to note, things are a bit more complicated than this because irssi leaks
memory if you overlap multiple keyboard input requests (it apparently stores
it's state in a global and happily overwrites the pointer without freeing the
old value if a new prompt comes in while the old one is there
Hi!
I have spent some time trying to fix the bug reported to the Debian SILC
package as #482145 [1], but solving this might require some pretty bad
tricks (or an API change).
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=482145
In the silc client (or the irssi plugin), during the first
Kp kp at valhallalegends.com and myself have already been working (somewhat)
on a fix for this as time permits. There are some fundamental design problems,
however, as the SilcClientConnection object is not referenced counted as it
must be (as you have noticed).
All of the key confirmation
5 matches
Mail list logo