Bug#505714: imlib2: diff for NMU version 1.4.0-1.2

2008-11-25 Thread Bas Zoetekouw
Hi Thomas! You wrote: I think this should be OK even end ends up ptr because some one of w,h is negative for some reason or an overflow, but I'm more happy to be corrected than have imlib2 in the release with an incorrect patch. :) Isee. Thanks for your analysis, and sorry for the noise.

Bug#505714: imlib2: diff for NMU version 1.4.0-1.2

2008-11-23 Thread Bas Zoetekouw
Hi! diff -u imlib2-1.4.0/src/modules/loaders/loader_xpm.c imlib2-1.4.0/src/modules/loaders/loader_xpm.c --- imlib2-1.4.0/src/modules/loaders/loader_xpm.c +++ imlib2-1.4.0/src/modules/loaders/loader_xpm.c @@ -246,8 +246,8 @@ return 0;

Bug#505714: imlib2: diff for NMU version 1.4.0-1.2

2008-11-23 Thread Thomas Viehmann
Hi, thanks for your attention to this. Bas Zoetekouw wrote: diff -u imlib2-1.4.0/src/modules/loaders/loader_xpm.c imlib2-1.4.0/src/modules/loaders/loader_xpm.c --- imlib2-1.4.0/src/modules/loaders/loader_xpm.c +++ imlib2-1.4.0/src/modules/loaders/loader_xpm.c @@ -246,8 +246,8 @@

Bug#505714: imlib2: diff for NMU version 1.4.0-1.2

2008-11-23 Thread Peter De Wachter
On Sun, 23 Nov 2008 20:22:27 +0100 Thomas Viehmann [EMAIL PROTECTED] wrote: Concretely: can't w*h still overflow in the code above, for a suitably crafted header? ptr and end are both DATA32*. ptr is initialized to im-data = (DATA32 *) malloc(sizeof(DATA32) * im-w * im-h); (im-w and

Bug#505714: imlib2: diff for NMU version 1.4.0-1.2

2008-11-22 Thread Thomas Viehmann
tags 505714 + patch pending thanks Hi Laurance, Here is the NMU for imlib2 (versioned as 1.4.0-1.2) and to be uploaded. Kind regards T. diff -u imlib2-1.4.0/debian/control imlib2-1.4.0/debian/control --- imlib2-1.4.0/debian/control +++ imlib2-1.4.0/debian/control @@ -2,7 +2,7 @@ Section: