Package: zapping
Version: 0.10~cvs6-2
Severity: important
Tags: patch

*** Please type your report below this line ***

I ran into the bug which is also reported here:

        https://bugs.launchpad.net/ubuntu/+source/zapping/+bug/304530

I looked at the kernel code, and it is possible that the ioctl
VIDIOC_REQBUFS can return a value greater than 0 on success.
This break's zapping's TV engine code, which assumes most ioctl's
return 0 on success.

Below is a hackish patch that got video working for me on a
Conexant card.  I'm still having trouble getting channels working,
but that's a separate problem.

- Chris

diff -ru zapping-0.10~cvs6/src/tveng25.c zapping-0.10~cvs6-cdf/src/tveng25.c
--- zapping-0.10~cvs6/src/tveng25.c     2006-06-07 02:56:51.000000000 -0400
+++ zapping-0.10~cvs6-cdf/src/tveng25.c 2009-05-10 18:05:30.000000000 -0400
@@ -2575,7 +2575,7 @@
        rb.memory = V4L2_MEMORY_MMAP;
        rb.count = n_buffers;
 
-       if (-1 == xioctl (info, VIDIOC_REQBUFS, &rb))
+       if (xioctl_may_fail (info, VIDIOC_REQBUFS, &rb) < 0)
                return FALSE;
 
        if (rb.count <= 0)




-- System Information:
Debian Release: 5.0.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.28.9snoopbuffuse (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to