Bug#559344: kldutils: bashism used in /etc/init.d/module-init-tools

2009-12-04 Thread Petr Salinger
When running with a default shell of dash and not bash, the /etc/init.d/module-init-tools script complains about not finding the bash builtin shopt: # /etc/init.d/module-init-tools start /etc/init.d/module-init-tools: 62: shopt: not found # Which is from this call: modules=`shopt -s

Bug#559344: kldutils: bashism used in /etc/init.d/module-init-tools

2009-12-04 Thread Hanno Hecker
On Fri, 4 Dec 2009 14:43:52 +0100 (CET) Petr Salinger petr.salin...@seznam.cz wrote: It might be related to package name change in freebsd-utils (7.1-4) unstable; urgency=low * Rename module-init-tools to kldutils and net-tools to freebsd-net-tools, as this is messing up the

Bug#559344: kldutils: bashism used in /etc/init.d/module-init-tools

2009-12-03 Thread Hanno Hecker
Package: kldutils Version: 8.0-1 Severity: normal When running with a default shell of dash and not bash, the /etc/init.d/module-init-tools script complains about not finding the bash builtin shopt: # /etc/init.d/module-init-tools start /etc/init.d/module-init-tools: 62: shopt: not found #

Bug#559344: kldutils: bashism used in /etc/init.d/module-init-tools

2009-12-03 Thread Thorsten Glaser
Hanno Hecker dixit: modules=`shopt -s nullglob ; cat /etc/modules /etc/modules.d/* \ | sed -e \s/#.*//g\ -e \/^\( \|\t\)*$/d\ ` This is even worse, as ...`.`... (with or without inner quotes) is always wrong and not portable, however $(...) is guaranteed by POSIX which then

Bug#559344: kldutils: bashism used in /etc/init.d/module-init-tools

2009-12-03 Thread Hanno Hecker
On Thu, 3 Dec 2009 20:44:03 + (UTC) Thorsten Glaser t...@mirbsd.de wrote: I propose: (untested at the moment though) modules=$(cat /etc/modules /etc/modules.d/* 2/dev/null | \ sed -e 's/#.*//g' -e '/^[ ]*$/d') ^ ^- space

Bug#559344: kldutils: bashism used in /etc/init.d/module-init-tools

2009-12-03 Thread Aurelien Jarno
On Thu, Dec 03, 2009 at 08:58:49PM +0100, Hanno Hecker wrote: Package: kldutils Version: 8.0-1 Severity: normal When running with a default shell of dash and not bash, the /etc/init.d/module-init-tools script complains about not finding the bash builtin shopt: #