Package: alacarte
Version: 0.12.4-1
Severity: normal
Tags: patch

--- Please enter the report below this line. ---

Hi,

the selection marker on the right pane of alacarte acts weirdly, if there is a
separator item above.

How to reproduce:
1) add a separator
2) select the next item below
3) click on the "move down" button on the right side

The selected item moves as expected. But afterwards the previous item is
selected (instead of the moved one).
This does not happen in lists without a separator item.

The attached patch fixes this issue.

thanks for your work,
Lars

--- System information. ---
Architecture: i386
Kernel:       Linux 2.6.30-2-686

Debian Release: squeeze/sid
  990 testing         localhost 

--- Package information. ---
Depends               (Version) | Installed
===============================-+-=============
python                 (>= 2.4) | 2.5.4-2
python-support      (>= 0.90.0) | 1.0.6
python-gtk2         (>= 2.13.0) | 2.16.0-1
python-gmenu       (>= 2.27.92) | 2.28.0.1-1
gnome-menus        (>= 2.27.92) | 2.28.0.1-1
python-gobject      (>= 2.15.1) | 2.20.0-1


Recommends       (Version) | Installed
==========================-+-===========
gnome-panel                | 2.28.0-3


Package's Suggests field is empty.

-- 

gpg key: https://systemausfall.org/schluessel/lars-devel.0.asc
diff -ruN Alacarte.orig/MainWindow.py Alacarte/MainWindow.py
--- Alacarte.orig/MainWindow.py	2009-12-21 22:59:55.000000000 +0100
+++ Alacarte/MainWindow.py	2009-12-22 00:02:32.000000000 +0100
@@ -128,6 +128,8 @@
 						found = True
 				if item[3].get_type() == gmenu.TYPE_SEPARATOR:
 					if not isinstance(item_id, tuple):
+						#we may not skip the increment via "continue"
+						i += 1
 						continue
 					#separators have no id, have to find them manually
 					#probably won't work with two separators together

Attachment: signature.asc
Description: PGP signature

Reply via email to