Package: signing-party Version: 1.1.3-1 Severity: wishlist File: /usr/bin/caff Tags: patch
Caff should show the photo id before asking the user if he wants to sign all ids. Without seeing the photo id it's hard to decide if one wants to sign the photo id or not. The current behaviour even encourages careless signing of non verified photo ids. The attached patch adds a showphoto command before the sign command while signing keys. The additional showphoto command does not harm even if no photo id is present. Gaudenz -- System Information: Debian Release: squeeze/sid APT prefers testing APT policy: (800, 'testing'), (700, 'unstable'), (50, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.35-trunk-amd64 (SMP w/2 CPU cores) Locale: LANG=de_CH.UTF-8, LC_CTYPE=de_CH.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages signing-party depends on: ii gnupg 1.4.10-4 GNU privacy guard - a free PGP rep ii libc6 2.11.2-2 Embedded GNU C Library: Shared lib ii libclass-methodmaker-perl 2.15-2 Perl module for creating generic m ii libgnupg-interface-perl 0.42-3 Perl interface to GnuPG ii libmailtools-perl 2.06-1 Manipulate email in perl programs ii libmime-tools-perl 5.428-1 Perl5 modules for MIME-compliant m ii libterm-readkey-perl 2.30-4 A perl module for simple terminal ii libtext-template-perl 1.45-1 Text::Template perl module ii perl 5.10.1-14 Larry Wall's Practical Extraction ii qprint 1.0.dfsg.2-2 encoder and decoder for quoted-pri Versions of packages signing-party recommends: ii dialog 1.1-20100428-1 Displays user-friendly dialog boxe ii libgd-gd2-noxpm-perl 1:2.39-2 Perl module wrapper for libgd - gd ii libintl-perl 1.20-1 Uniforum message translations syst ii libpaper-utils 1.1.24 library for handling paper charact ii libtext-iconv-perl 1.7-2 converts between character sets in ii postfix [mail-transport-a 2.7.1-1 High-performance mail transport ag ii recode 3.6-17 Character set conversion utility ii whiptail 0.52.11-1 Displays user-friendly dialog boxe Versions of packages signing-party suggests: ii imagemagick 8:6.6.0.4-2.1+b1 image manipulation programs ii mutt 1.5.20-9 text-based mailreader supporting M ii texlive-latex-recommend 2009-10 TeX Live: LaTeX recommended packag ii wipe 0.21-9 Secure file deletion -- no debconf information
--- /usr/bin/caff.orig 2010-08-24 22:17:40.578674539 +0200 +++ /usr/bin/caff 2010-08-24 22:20:45.000000000 +0200 @@ -1158,6 +1158,7 @@ push @command, '--no-auto-check-trustdb'; push @command, '--trust-model=always'; push @command, '--edit', $keyid; + push @command, 'showphoto'; push @command, 'sign'; push @command, split ' ', $CONFIG{'gpg-sign-args'} || ""; print join(' ', @command),"\n";