Bug#598375: live-config: hooks on media do not run

2010-09-30 Thread Daniel Baumann
On 09/28/2010 10:55 PM, Scott Barker wrote: I'm pretty sure that the first for loop in the script is incorrect as well. The case statement uses ${LIVE_HOOKS} instead of ${_HOOK}, which doesn't work if more than one hook is defined. fixed, thanks. -- Address:Daniel Baumann,

Bug#598375: live-config: hooks on media do not run

2010-09-30 Thread Daniel Baumann
On 09/28/2010 11:10 PM, Scott Barker wrote: There is also a faulty if statement on line 56. This is incorrect: if $(echo ${_HOOK} | grep file:\/\/) this is correct: if (echo ${_HOOK} | grep file:\/\/) not really, the proper way to do it is if echo ${_HOOK} | grep -qs file://

Bug#598375: live-config: hooks on media do not run

2010-09-28 Thread Scott Barker
Package: live-config Version: 2.0.7+20100926.070409~60squeeze+1 Severity: normal The 999-hooks script allows filesystem and media as options to the hooks= boot argument, however, it tries to use wget to copy them, and wget just complains Scheme missing. If there is no scheme specified, the

Bug#598375: live-config: hooks on media do not run

2010-09-28 Thread Daniel Baumann
tag 598375 moreinfo thanks On 09/28/2010 05:19 PM, Scott Barker wrote: The 999-hooks script allows filesystem and media as options to the hooks= boot argument, however, it tries to use wget to copy them, and wget just complains Scheme missing. If there is no scheme specified, the script

Bug#598375: live-config: hooks on media do not run

2010-09-28 Thread Scott Barker
I specified hooks=medium, so the script found the hooks in /live/hooks/*, but then uses them as raw filenames, without pre-pending file:// to them. On Tue, Sep 28, 2010 at 07:09:02PM +0200, Daniel Baumann wrote: tag 598375 moreinfo thanks On 09/28/2010 05:19 PM, Scott Barker wrote: The

Bug#598375: live-config: hooks on media do not run

2010-09-28 Thread Daniel Baumann
tag 598375 - moreinfo tag 598375 pending thanks On 09/28/2010 07:18 PM, Scott Barker wrote: I specified hooks=medium, so the script found the hooks in /live/hooks/*, but then uses them as raw filenames, without pre-pending file:// to them. ah, right. fixed in git. thanks you for reporting it.

Bug#598375: live-config: hooks on media do not run

2010-09-28 Thread Scott Barker
I'm pretty sure that the first for loop in the script is incorrect as well. The case statement uses ${LIVE_HOOKS} instead of ${_HOOK}, which doesn't work if more than one hook is defined. -- Scott Barker sc...@mostlylinux.ca Linux Consultant http://www.mostlylinux.ca/scott -- To

Bug#598375: live-config: hooks on media do not run

2010-09-28 Thread Scott Barker
There is also a faulty if statement on line 56. This is incorrect: if $(echo ${_HOOK} | grep file:\/\/) this is correct: if (echo ${_HOOK} | grep file:\/\/) Probably file:\/\/ could also just be file://. I think in the sed statement, file\:// could just be file:// as well. -- Scott