Bug#610624: [Build-common-hackers] Bug#610624: Bug#610624: cdbs: Multiple regressions in python-autotools.mk

2011-01-23 Thread Jonas Smedegaard
On Sat, Jan 22, 2011 at 12:25:37AM +0200, Stefano Rivera wrote: Hi Emilio (2011.01.21_23:16:46_+0200) # Install all flavors on top of each other by default -DEB_MAKE_DESTDIRSKEL ?= $(cdbs_curdestdir) +DEB_MAKE_DESTDIRSKEL = $(cdbs_curdestdir) Not so sure about this one though. What is

Bug#610624: [Build-common-hackers] Bug#610624: cdbs: Multiple regressions in python-autotools.mk

2011-01-22 Thread Emilio Pozuelo Monfort
On 21/01/11 22:25, Stefano Rivera wrote: Hi Emilio (2011.01.21_23:16:46_+0200) # Install all flavors on top of each other by default -DEB_MAKE_DESTDIRSKEL ?= $(cdbs_curdestdir) +DEB_MAKE_DESTDIRSKEL = $(cdbs_curdestdir) Not so sure about this one though. What is setting DEB_MAKE_DESTDIRSKEL

Bug#610624: [Build-common-hackers] Bug#610624: cdbs: Multiple regressions in python-autotools.mk

2011-01-22 Thread Stefano Rivera
Hi Emilio (2011.01.22_18:46:34_+0200) Ah right. So your patch is correct. However this will make DEB_MAKE_DESTDIRSKEL non-overridable when using python-autotools.mk. Can it not be overriden after the includes? SR -- Stefano Rivera http://tumbleweed.org.za/ H: +27 21 465 6908 C: +27 72

Bug#610624: [Build-common-hackers] Bug#610624: cdbs: Multiple regressions in python-autotools.mk

2011-01-22 Thread Emilio Pozuelo Monfort
On 22/01/11 16:55, Stefano Rivera wrote: Hi Emilio (2011.01.22_18:46:34_+0200) Ah right. So your patch is correct. However this will make DEB_MAKE_DESTDIRSKEL non-overridable when using python-autotools.mk. Can it not be overriden after the includes? Right. I was going to apply your

Bug#610624: [Build-common-hackers] Bug#610624: cdbs: Multiple regressions in python-autotools.mk

2011-01-21 Thread Emilio Pozuelo Monfort
On 20/01/11 14:42, Stefano Rivera wrote: --- a/1/class/python-autotools.mk.in +++ b/1/class/python-autotools.mk.in @@ -39,10 +39,10 @@ CDBS_BUILD_DEPENDS_class_python-autotools_python ?= $(cdbs_python_builddeps) CDBS_BUILD_DEPENDS += , $(CDBS_BUILD_DEPENDS_class_python-autotools_python) #

Bug#610624: [Build-common-hackers] Bug#610624: cdbs: Multiple regressions in python-autotools.mk

2011-01-21 Thread Stefano Rivera
Hi Emilio (2011.01.21_23:16:46_+0200) # Install all flavors on top of each other by default -DEB_MAKE_DESTDIRSKEL ?= $(cdbs_curdestdir) +DEB_MAKE_DESTDIRSKEL = $(cdbs_curdestdir) Not so sure about this one though. What is setting DEB_MAKE_DESTDIRSKEL ? Nothing in CDBS sets it AFAICS.

Bug#610624: cdbs: Multiple regressions in python-autotools.mk

2011-01-20 Thread Stefano Rivera
Package: cdbs Version: 0.4.91 Severity: normal Tags: patch There are two regressions in python-autotools.mk, first appearing in 0.4.90. This is an example with pywebkitgtk on natty (sorry can't think of any good examples that'll build on experimental) First issue, missing quote: | cd