Source: firestarter Severity: minor Version: 1.0.3-9 User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu ubuntu-patch natty Tags: patch thanks
Hello, i checked firestarter desktop files with desktop-file-validate and i got errors. referring standards.freedesktop.org an icon must not have extension, and i believe Categories fields is wrong. $ desktop-file-validate firestarter.desktop firestarter.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated firestarter.desktop: warning: value "firestarter.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path firestarter.desktop: warning: value "System;Application;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application" Here is a patch to fixing it #! /bin/sh /usr/share/dpatch/dpatch-run ## Description: Removed extension in icon field, change System;Application; -> System;Security; ## Author: Mahyuddin Susanto <udi...@ubuntu.com> @DPATCH@ diff -urNad firestarter-1.0.3-9ubuntu1.broken~/firestarter.desktop.in firestarter-1.0.3-9ubuntu1.broken/firestarter.desktop.in --- firestarter-1.0.3-9ubuntu1.broken~/firestarter.desktop.in 2011-01-28 00:43:47.287666062 +0700 +++ firestarter-1.0.3-9ubuntu1.broken/firestarter.desktop.in 2011-01-28 00:44:13.807679778 +0700 @@ -2,10 +2,10 @@ _Name=Firestarter _Comment=Desktop Firewall Tool Exec=su-to-root -X -c /usr/sbin/firestarter -Icon=firestarter.png +Icon=firestarter Terminal=false Type=Application StartupNotify=true -Categories=System;GNOME;Network;Settings; +Categories=System;Security; X-GNOME-Bugzilla-Bugzilla=GNOME X-GNOME-Bugzilla-Product=firestarter -- Mahyuddin Susanto udienz at ubuntu.com | http://tripledin.wordpress.com/
signature.asc
Description: OpenPGP digital signature
