Bug#622365: Fix FTBFS of tofrodos for GNU/Hurd

2011-04-16 Thread Svante Signell
On Sat, 2011-04-16 at 02:42 +0200, Guillem Jover wrote: > Hi! > > On Tue, 2011-04-12 at 21:46:09 +0200, Svante Signell wrote: > > Final version?? > > > diff -ur tofrodos-1.7.8.debian.1/src/tofrodos.c > > tofrodos-1.7.8.debian.1.new/src/tofrodos.c > > --- tofrodos-1.7.8.debian.1/src/tofrodos.c 2

Bug#622365: Fix FTBFS of tofrodos for GNU/Hurd

2011-04-15 Thread Guillem Jover
Hi! On Tue, 2011-04-12 at 21:46:09 +0200, Svante Signell wrote: > Final version?? > diff -ur tofrodos-1.7.8.debian.1/src/tofrodos.c > tofrodos-1.7.8.debian.1.new/src/tofrodos.c > --- tofrodos-1.7.8.debian.1/src/tofrodos.c2011-04-12 18:21:50.0 > +0200 > +++ tofrodos-1.7.8.debian.1/sr

Bug#622365: Fix FTBFS of tofrodos for GNU/Hurd

2011-04-12 Thread Samuel Thibault
Svante Signell, le Tue 12 Apr 2011 21:46:09 +0200, a écrit : > On Tue, 2011-04-12 at 20:56 +0200, Samuel Thibault wrote: > > Svante Signell, le Tue 12 Apr 2011 19:27:10 +0200, a écrit : > > > return -1 ; > > > } > > > /* If we reach here, "filename" is not a symbolic link */ > > > >

Bug#622365: Fix FTBFS of tofrodos for GNU/Hurd

2011-04-12 Thread Svante Signell
On Tue, 2011-04-12 at 20:56 +0200, Samuel Thibault wrote: > Svante Signell, le Tue 12 Apr 2011 19:27:10 +0200, a écrit : > > return -1 ; > > } > > /* If we reach here, "filename" is not a symbolic link */ > > And thus we didn't call realpath at all. I believe the free below >

Bug#622365: Fix FTBFS of tofrodos for GNU/Hurd

2011-04-12 Thread Samuel Thibault
Svante Signell, le Tue 12 Apr 2011 19:27:10 +0200, a écrit : > return -1 ; > } > /* If we reach here, "filename" is not a symbolic link */ And thus we didn't call realpath at all. I believe the free below shouldn't be done, it's probably only by chance that it doesn't se

Bug#622365: Fix FTBFS of tofrodos for GNU/Hurd

2011-04-12 Thread Svante Signell
On Tue, 2011-04-12 at 17:59 +0200, Svante Signell wrote: > On Tue, 2011-04-12 at 17:39 +0200, Samuel Thibault wrote: > > Svante Signell, le Tue 12 Apr 2011 16:33:14 +0200, a écrit : > > > if (verbose) { > > > emsg( VERBOSE_SYMLINKSRC, filename, > > > rea

Bug#622365: Fix FTBFS of tofrodos for GNU/Hurd

2011-04-12 Thread Svante Signell
On Tue, 2011-04-12 at 17:39 +0200, Samuel Thibault wrote: > Svante Signell, le Tue 12 Apr 2011 16:33:14 +0200, a écrit : > > if (verbose) { > > emsg( VERBOSE_SYMLINKSRC, filename, > > realfilepath ); > > } > >

Bug#622365: Fix FTBFS of tofrodos for GNU/Hurd

2011-04-12 Thread Samuel Thibault
Svante Signell, le Tue 12 Apr 2011 16:33:14 +0200, a écrit : > if (verbose) { > emsg( VERBOSE_SYMLINKSRC, filename, > realfilepath ); > } > return openandconvert( realfilepath ); > } You

Bug#622365: tofrodos Re: Bug#622365: Fix FTBFS of tofrodos for GNU/Hurd

2011-04-12 Thread Steffen Möller
You are producing a memory leak. Try not to. S -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#622365: Fix FTBFS of tofrodos for GNU/Hurd

2011-04-12 Thread Svante Signell
Package: tofrodos Version: 1.7.8.debian.1-2 Severity: important Tags: patch Usertags: hurd Attached is a patch to enable successful build of tofrodos on GNU/Hurd. It should be applied after the FTBFS_kfreebsd.diff patch. The only question is if I've missed a free() somewhere. In my opinion it does