Bug#633627: /usr/bin/update-alternatives: removes regular files when removing slave alternatives because the current selection is missing a particular slave

2011-07-16 Thread Raphael Hertzog
On Sat, 16 Jul 2011, Andreas Beckmann wrote: OK, patch attached. Thanks! That fixes most regressions I could produce in above patch. There is one left when --force is used, I'm not sure if I did this correctly or I found another bug. In fact set_choice() did not support passing

Bug#633627: /usr/bin/update-alternatives: removes regular files when removing slave alternatives because the current selection is missing a particular slave

2011-07-16 Thread Andreas Beckmann
On 2011-07-16 09:01, Raphael Hertzog wrote: +ok(-f $bindir/slave2, forced switching w/o slave keeps real files installed as slave links); This test was reversed, with --force it must remove the file. Probably depends on your interpretation of --force. I would leave real files in the place

Bug#633627: /usr/bin/update-alternatives: removes regular files when removing slave alternatives because the current selection is missing a particular slave

2011-07-16 Thread Raphael Hertzog
On Sat, 16 Jul 2011, Andreas Beckmann wrote: This test was reversed, with --force it must remove the file. Probably depends on your interpretation of --force. To avoid any ambiguity I updated the manual page to indicate that --force also allows the removal of files which are in place where

Bug#633627: /usr/bin/update-alternatives: removes regular files when removing slave alternatives because the current selection is missing a particular slave

2011-07-15 Thread Raphael Hertzog
On Tue, 12 Jul 2011, Andreas Beckmann wrote: The following script demonstrates the problem: Thank you for your report and your test script. Do you think you could update the non-regression test-suite of update-alternatives to reproduce the problem? This is much more useful than just a test

Bug#633627: /usr/bin/update-alternatives: removes regular files when removing slave alternatives because the current selection is missing a particular slave

2011-07-15 Thread Raphael Hertzog
tag 633627 + patch thanks On Fri, 15 Jul 2011, Raphael Hertzog wrote: In the mean time, I will look into fixing this regression. Here's a patch, can you tell me if it works for you? Cheers, -- Raphaël Hertzog ◈ Debian Developer Follow my Debian News ▶ http://RaphaelHertzog.com (English)

Bug#633627: /usr/bin/update-alternatives: removes regular files when removing slave alternatives because the current selection is missing a particular slave

2011-07-15 Thread Andreas Beckmann
On 2011-07-15 21:32, Raphael Hertzog wrote: Thank you for your report and your test script. Do you think you could update the non-regression test-suite of update-alternatives to reproduce the problem? OK, patch attached. On 2011-07-15 22:08, Raphael Hertzog wrote: tag 633627 + patch thanks

Bug#633627: /usr/bin/update-alternatives: removes regular files when removing slave alternatives because the current selection is missing a particular slave

2011-07-12 Thread Andreas Beckmann
Package: dpkg Version: 1.15.8.11 Severity: important File: /usr/bin/update-alternatives Tags: sid squeeze Hi, update-alternatives happily removes regular files that are in place of alternative slave links if the currently selected alternative does not have that particular slave. This is a