Bug#642115: debian-installer: guided full disk encryption + LVM complains about insecure swap

2011-09-20 Thread Jon Dowland
On Mon, Sep 19, 2011 at 11:56:49AM -0400, Joey Hess wrote: The code is this, and Max changed it most recently: # Accept e.g. swap on lvm on crypto if echo $device | grep -q ^/dev/mapper/; then if dm_is_safe $device; then continue

Bug#642115: debian-installer: guided full disk encryption + LVM complains about insecure swap

2011-09-20 Thread Jon Dowland
On Tue, Sep 20, 2011 at 11:54:21AM +0100, Jon Dowland wrote: Thus the outer-if is passing. dm_is_safe looks fine to me, at least it invokes dm_dev_is_safe, I'll try to look at dm_dev_is_safe next. I think this is where the problem is. crypto-base.sh, dm_dev_is_safe: dminfo=$(dmsetup table

Bug#642115: debian-installer: guided full disk encryption + LVM complains about insecure swap

2011-09-20 Thread Joey Hess
Jon Dowland wrote: I've just monkey-patched this instance of d-i to write $device to a temporary file. Welcome to d-i development. ;-) dminfo=$(dmsetup table -j$mag -m$min 2 /dev/null | \ head -n1 | cut -d' ' -f3) || return 1 dmsetup table -j$mag -m$min returns:

Bug#642115: debian-installer: guided full disk encryption + LVM complains about insecure swap

2011-09-19 Thread Jon Dowland
Package: debian-installer Severity: normal Hi, Using a daily build: -rw-r--r-- 1 libvirt-qemu kvm 240M Sep 16 10:00 debian-testing-i386-netinst.iso If you choose Guided / Encrypted / LVM as the partitioning type, the resulting scheme chosen by d-i basically looks like (physical

Bug#642115: debian-installer: guided full disk encryption + LVM complains about insecure swap

2011-09-19 Thread Joey Hess
Jon Dowland wrote: If you choose Guided / Encrypted / LVM as the partitioning type, the resulting scheme chosen by d-i basically looks like (physical partition) → (encrypted volume) → (LVM) → (swap) Thus, the swap is encrypted, but LVM sits between them. The code is this, and Max