Bug#656766: xscreensaver seems to ignore pam-blocked accounts

2012-09-05 Thread Mamoru Tasaka
My patch got applied in xscreensaver 5.16. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#656766: (xscreensaver seems to ignore pam-blocked accounts)

2012-06-18 Thread Jamie Zawinski
Looks reasonable, thanks! -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#656766: (xscreensaver seems to ignore pam-blocked accounts)

2012-06-17 Thread TASAKA Mamoru
I think the attached patch is more in shape which can be accepted by Jamie. The attached patch does the following: - The default follows the current xscreensaver 5.15 behavior. - Accept the configure option "--enable-pam-check-account-type" as explained in the patch. - Modify driver/xscreensave

Bug#656766: xscreensaver seems to ignore pam-blocked accounts

2012-06-16 Thread TASAKA Mamoru
Well, unless I am wrong, the diff in the message 22 breaks xscreensaver's default pam settings (i.e. settings written as driver/xscreensaver.pam). driver/xscreensaver.pam essentially just writes: - #%PAM-1.0 auth include system-auth --

Bug#656766: xscreensaver seems to ignore pam-blocked accounts

2012-04-23 Thread Jamie Zawinski
This is a large-ish patch to a sensitive piece of code and I honestly can't tell what it's trying to do. So without a better explanation (and hopefully better commented code) I'm not going to apply this upstream. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a sub

Bug#656766: xscreensaver seems to ignore pam-blocked accounts

2012-01-28 Thread Tormod Volden
On Sat, Jan 28, 2012 at 9:39 PM, Yann Dirson wrote: > On Sat, Jan 21, 2012 at 06:21:01PM +0100, Yann Dirson wrote: >> In fact, the source says: >> >>       /* We don't actually care if the account modules fail or succeed, >>        * but we need to run them anyway because certain pam modules >>  

Bug#656766: xscreensaver seems to ignore pam-blocked accounts

2012-01-28 Thread Yann Dirson
On Sat, Jan 21, 2012 at 06:21:01PM +0100, Yann Dirson wrote: > In fact, the source says: > > /* We don't actually care if the account modules fail or succeed, >* but we need to run them anyway because certain pam modules >* depend on side effects of the account modules gettin

Bug#656766: xscreensaver seems to ignore pam-blocked accounts

2012-01-21 Thread Yann Dirson
In fact, the source says: /* We don't actually care if the account modules fail or succeed, * but we need to run them anyway because certain pam modules * depend on side effects of the account modules getting run. */ Looks like this decision was done using wrong assumpt

Bug#656766: xscreensaver seems to ignore pam-blocked accounts

2012-01-21 Thread Yann Dirson
Package: xscreensaver Version: 5.15-2 Severity: important Ob-important: pam-aware program apparently not respecting user policy Adding the following to common-account and setting up a config in time.conf does result in users getting barred from eg. "login", and does trigger a "xscreensaver: pam_t