Bug#658408: libapache2-mod-shib2: FTBFS with libmemcached-dev-1.0.3-1

2012-02-06 Thread Michael Fladischer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/2012 05:49 AM, Russ Allbery wrote: Thanks! I checked the libmemcached 1.0 source and can confirm that this will work, although it will duplicate the SYSTEM ERROR string since memcached_strerror will already add that. But it will fix the

Bug#658408: libapache2-mod-shib2: FTBFS with libmemcached-dev-1.0.3-1

2012-02-06 Thread Cantor, Scott
Scott, in the long run it looks like you can merge the _ERRNO case with the case below it when doing error reporting and remove the SYSTEM ERROR or Problems part of the suffix, since memcached_last_error_message() will add all that stuff for you. Unfortunately, though, that function is new

Bug#658408: libapache2-mod-shib2: FTBFS with libmemcached-dev-1.0.3-1

2012-02-06 Thread Russ Allbery
Cantor, Scott canto...@osu.edu writes: Scott, in the long run it looks like you can merge the _ERRNO case with the case below it when doing error reporting and remove the SYSTEM ERROR or Problems part of the suffix, since memcached_last_error_message() will add all that stuff for you.

Bug#658408: libapache2-mod-shib2: FTBFS with libmemcached-dev-1.0.3-1

2012-02-04 Thread Russ Allbery
Michael Fladischer mich...@fladi.at writes: Here's a simple patch to fix this bug. I tested it on amd64 and i386 and it built fine. Thanks! I checked the libmemcached 1.0 source and can confirm that this will work, although it will duplicate the SYSTEM ERROR string since memcached_strerror

Bug#658408: libapache2-mod-shib2: FTBFS with libmemcached-dev-1.0.3-1

2012-02-03 Thread Michael Fladischer
Here's a simple patch to fix this bug. I tested it on amd64 and i386 and it built fine. Cheers, -- Michael Fladischer mich...@fladi.at --- a/memcache-store/memcache-store.cpp +++ b/memcache-store/memcache-store.cpp @@ -308,7 +308,7 @@ success = false; } else if (rv == MEMCACHED_ERRNO) {

Bug#658408: libapache2-mod-shib2: FTBFS with libmemcached-dev-1.0.3-1

2012-02-03 Thread Russ Allbery
Michael Fladischer mich...@fladi.at writes: According to [0] it should be: if (rv == MEMCACHED_ERRNO) { // System error string error = string(Memcache::deleteMemcache() SYSTEM ERROR: ) + string(memcached_last_error_message(memc)); log.error(error); throw

Bug#658408: libapache2-mod-shib2: FTBFS with libmemcached-dev-1.0.3-1

2012-02-02 Thread Michael Fladischer
Package: libapache2-mod-shib2 Version: 2.4.3+dfsg-4 Severity: normal -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Building the package with libmemcached-dev-1.0.3-1 FTBFS: /bin/bash ../libtool --silent --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I.. -I../shibsp -pthread -g -Wall -O2

Bug#658408: libapache2-mod-shib2: FTBFS with libmemcached-dev-1.0.3-1

2012-02-02 Thread Russ Allbery
Michael Fladischer fladischermich...@fladi.at writes: Building the package with libmemcached-dev-1.0.3-1 FTBFS: memcache-store.cpp: In member function 'bool xmltooling::MemcacheBase::deleteMemcache(const char*, time_t, bool)': memcache-store.cpp:311:96: error: 'struct memcached_st' has no

Bug#658408: libapache2-mod-shib2: FTBFS with libmemcached-dev-1.0.3-1

2012-02-02 Thread Michael Fladischer
On 02/03/2012 02:30 AM, Russ Allbery wrote: The code in Shibboleth is all along these lines: } else if (rv == MEMCACHED_ERRNO) { // System error string error = string(Memcache::deleteMemcache() SYSTEM ERROR: ) + string(strerror(memc-cached_errno)); log.error(error);