-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 03/12/12 17:05, Joey Hess wrote:
I added a check for autoexec.bat || config.sys , just to have an added check
and avoid the worse of the false positives. My gut feeling is that either a)
nobody cares if their DOS is not detected, or b) if
On Mon, Mar 12, 2012 at 12:11:29PM -0400, Joey Hess wrote:
Colin Watson wrote:
How about, if grub-mount is used, we use grub-probe to find out which
GRUB filesystem driver is in use, and stash that somewhere so that
individual tests can get at it? That ought to be just as reliable as
the
On 12.03.2012 08:57, Harald Dunkel wrote:
Package: os-prober
Version: 1.49
os-prober finds some MSDOS partition on my laptop:
[os-prober says /dev/sda2 is MSDOS,
while parted and blkid identifies it as ext4]
I understand that, due to the fact that other utils correctly identifies
this
Michael Tokarev wrote:
So a more naive approach at determining the filesystem type is to
check first 512 bytes, and if MS-DOS signature is found there,
report that it is MS-DOS. This is, apparently, what os-prober is
currently doing.
os-prober does not look at fragile magic numbers in
Joey Hess, le Mon 12 Mar 2012 11:14:07 -0400, a écrit :
The particular OS string we see here comes from:
# MS-DOS
if [ -z $found ] item_in_dir -q dos $2
[ -d $2/$(item_in_dir dos $2) ]; then
long=MS-DOS 5.x/6.x/Win3.1
short=MS-DOS
found=true
fi
On Mon, Mar 12, 2012 at 11:14:07AM -0400, Joey Hess wrote:
These checks don't try to avoid false positives like a /dos or /windows,
because the code earlier checks that the mounted filesystem is one of ntfs,
vfat, or msdos. To which list was semi-recently added fuse, and I suspect
that might
Samuel Thibault wrote:
Mmm, why not looking for io.sys at the root? In all the versions of DOS
that I know there has to be one for the partition to be bootable.
According to http://en.wikipedia.org/wiki/IO.SYS , some of the DOS
clones did not use io.sys, which may be why I don't remember it
Colin Watson wrote:
How about, if grub-mount is used, we use grub-probe to find out which
GRUB filesystem driver is in use, and stash that somewhere so that
individual tests can get at it? That ought to be just as reliable as
the existing OS filesystem type checks.
Yes please. I've CCed the
Package: os-prober
Version: 1.49
os-prober finds some MSDOS partition on my laptop:
# os-prober
/dev/sda2:MS-DOS 5.x/6.x/Win3.1:MS-DOS:chain
# blkid | sort
/dev/sda1: UUID=063e2d53-7007-4112-822f-edcba00d2928 TYPE=ext4 LABEL=root
/dev/sda2: LABEL=debian UUID=af0b76b9-e91e-4bbd-a64c-b1a6199982bf
9 matches
Mail list logo
