Bug#679198: bash: [on native FreeBSD] unable to set FD_CLOEXEC flag

2012-12-12 Thread Jonathan Nieder
Hi, Nicolas Boulenguez wrote: > --- bash-4.2/debian/changelog > +++ bash-4.2/debian/changelog > @@ -1,3 +1,10 @@ > +bash (4.2-5.1) unstable; urgency=low > + > + * Non-maintainer upload. > + * debian/bash.preinst-lib.c: typo in fcntl argument (Closes: #679198). It would be clearer to users (who

Bug#679198: bash: [on native FreeBSD] unable to set FD_CLOEXEC flag

2012-11-28 Thread Jonathan Nieder
Nicolas Boulenguez wrote: > If I understand well fcntl(2), the following patch may solve this bug. > Stefan, would you please try to rebuild and test? > > --- bash.preinst-lib.c 2012-11-28 15:56:04.0 +0100 > +++ bash.preinst-lib.c.new 2012-11-28 17:07:09.0 +0100 > @@ -60,8 +6

Bug#679198: bash: [on native FreeBSD] unable to set FD_CLOEXEC flag

2012-11-28 Thread Steven Chamberlain
Control: tags -1 patch On 03/07/12 17:47, Jonathan Nieder wrote: > F_GETFL is 3, so fcntl is being called correctly. But why does > fcntl(F_GETFL) return 1 (== FD_CLOEXEC)? This looks like a bug. On 28/11/12 16:17, Nicolas Boulenguez wrote: > - int flags = fcntl(fd, F_GETFL); > - if

Bug#679198: bash: [on native FreeBSD] unable to set FD_CLOEXEC flag

2012-11-28 Thread Nicolas Boulenguez
Package: bash Followup-For: Bug #679198 If I understand well fcntl(2), the following patch may solve this bug. Stefan, would you please try to rebuild and test? --- bash.preinst-lib.c 2012-11-28 15:56:04.0 +0100 +++ bash.preinst-lib.c.new 2012-11-28 17:07:09.0 +0100 @@ -60,8

Bug#679198: bash: [on native FreeBSD] unable to set FD_CLOEXEC flag

2012-06-30 Thread Steven Chamberlain
On 30/06/12 04:23, Jonathan Nieder wrote: > When did O_CLOEXEC get involved? This report was about a use of > FD_CLOEXEC. I've been *assuming* (as the only thing that makes sense) the situation is something like: Enabling FD_CLOEXEC on an open fd was previously not implemented (in the upstream k

Bug#679198: bash: [on native FreeBSD] unable to set FD_CLOEXEC flag

2012-06-29 Thread Jonathan Nieder
Hi Robert, Robert Millan wrote: > This isn't a kernel bug. The kernel recognizes O_CLOEXEC properly > when userland uses it. > > The problem is that userland isn't actually using O_CLOEXEC, because > its declaration is missing in glibc headers. Actually it's already > been reported: see #679198

Bug#635192: Processed: Bug#679198: bash: [on native FreeBSD] unable to set FD_CLOEXEC flag

2012-06-29 Thread Robert Millan
2012/6/29 Steven Chamberlain : > #679198 is this bug.  Did you mean #635192? Yes, sorry. > In /usr/include/i386-kfreebsd-gnu/bits/fcntl.h : > >> #if _POSIX_C_SOURCE >= 200809L >> #define O_TTY_INIT      0x0008      /* Restore default termios >> attributes */ >> /* Defining O_CLOEXEC would br

Bug#679198: Processed: Bug#679198: bash: [on native FreeBSD] unable to set FD_CLOEXEC flag

2012-06-29 Thread Steven Chamberlain
On 29/06/12 20:28, Robert Millan wrote: > The problem is that userland isn't actually using O_CLOEXEC, because > its declaration is missing in glibc headers. Actually it's already > been reported: see #679198. #679198 is this bug. Did you mean #635192? In /usr/include/i386-kfreebsd-gnu/bits/fcn

Bug#679198: Processed: Bug#679198: bash: [on native FreeBSD] unable to set FD_CLOEXEC flag

2012-06-29 Thread Robert Millan
reassign 679198 bash thanks 2012/6/29 Debian Bug Tracking System : > Processing commands for cont...@bugs.debian.org: > >> reassign 679198 src:kfreebsd-9 This isn't a kernel bug. The kernel recognizes O_CLOEXEC properly when userland uses it. The problem is that userland isn't actually using O_

Bug#679198: bash: [on native FreeBSD] unable to set FD_CLOEXEC flag

2012-06-29 Thread Steven Chamberlain
On 29/06/12 14:12, Stefan Ott wrote: > Interesting. If you have a ideas / patches that I could try out I > would be happy to. You could rebuild bash with Jonathan Nieder's patch, and use it locally http://lists.debian.org/20120627015952.GH7701@burratino It would be nice to fix this, as bash is a

Bug#679198: bash: [on native FreeBSD] unable to set FD_CLOEXEC flag

2012-06-29 Thread Stefan Ott
On Fri, Jun 29, 2012 at 1:41 PM, Steven Chamberlain wrote: > reassign 679198 src:kfreebsd-9 > affects 679198 src:bash > retitle 679198 bash: [on native FreeBSD] unable to set FD_CLOEXEC flag > thanks > > On 29/06/12 03:19, Stefan Ott wrote: >> I suppose that narrows it down a little. I'm more and

Bug#679198: bash: [on native FreeBSD] unable to set FD_CLOEXEC flag

2012-06-29 Thread Steven Chamberlain
reassign 679198 src:kfreebsd-9 affects 679198 src:bash retitle 679198 bash: [on native FreeBSD] unable to set FD_CLOEXEC flag thanks On 29/06/12 03:19, Stefan Ott wrote: > I suppose that narrows it down a little. I'm more and more inclined to > blame ZFS. But /dev/null itself is on a devfs so I d