Bug#682156: groupdel performance

2022-07-22 Thread Marc Haber
On Thu, Jul 14, 2022 at 03:56:40PM -0400, Matt Barry wrote: > We can do as suggested above and remove our own (arguably superfluous) > check, and take the minor performance win. You have my approval, go ahead if you feel like doing so. Greetings Marc

Bug#682156: groupdel performance

2022-07-14 Thread Matt Barry
On Thu, 2022-07-14 at 21:54 +0200, Marc Haber wrote: > On Thu, Jul 14, 2022 at 03:00:50PM -0400, Matt Barry wrote: > > Any objections to either moving this bug to passwd, or just > > wontfix'ing > > this? > > No objection from me, I'd just reassign the bug. If we can do > something > to speed

Bug#682156: groupdel performance

2022-07-14 Thread Marc Haber
On Thu, Jul 14, 2022 at 03:00:50PM -0400, Matt Barry wrote: > Any objections to either moving this bug to passwd, or just wontfix'ing > this? No objection from me, I'd just reassign the bug. If we can do something to speed deletion up while having more pretty code, we should do that anyway

Bug#682156: groupdel performance

2022-07-14 Thread Matt Barry
Hi, I have added a test to benchmark the deletion of groups on a system with tens of thousands of users, and it is indeed (still) not great. However, removing the overhead described in this bug (and replacing it with *nothing*) only yields < 10-15% speed-up. I would not be opposed to relying on