Package: acl
Version: 2.2.51-8
Severity: normal
Tags: patch

Dear Maintainer,

The LDFLAGS hardening flags are missing for libmisc because are
overwritten in the Makefile. For more hardening information
please have a look at [1], [2] and [3].

The attached patch fixes the issue.

To check if all flags were correctly enabled you can use
`hardening-check` from the hardening-includes package and check
the build log with `blhc` (hardening-check doesn't catch
everything):

    $ hardening-check /bin/chacl /bin/setfacl /bin/getfacl
    /bin/chacl:
     Position Independent Executable: no, normal executable!
     Stack protected: no, not found!
     Fortify Source functions: yes
     Read-only relocations: yes
     Immediate binding: no not found!
    /bin/setfacl:
     Position Independent Executable: no, normal executable!
     Stack protected: yes
     Fortify Source functions: yes (some protected functions found)
     Read-only relocations: yes
     Immediate binding: no not found!
    /bin/getfacl:
     Position Independent Executable: no, normal executable!
     Stack protected: yes
     Fortify Source functions: yes (some protected functions found)
     Read-only relocations: yes
     Immediate binding: no not found!

(Position Independent Executable and Immediate binding is not
enabled by default.)

Use find -type f \( -executable -o -name \*.so\* \) -exec
hardening-check {} + on the build result to check all files.

Regards,
Simon

[1]: https://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags
[2]: https://wiki.debian.org/HardeningWalkthrough
[3]: https://wiki.debian.org/Hardening
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
Description: Use build flags from environment (dpkg-buildflags).
 Necessary for hardening flags.
Author: Simon Ruderich <si...@ruderich.org>
Last-Update: 2012-09-13

--- acl-2.2.51.orig/libmisc/Makefile
+++ acl-2.2.51/libmisc/Makefile
@@ -20,7 +20,7 @@ TOPDIR = ..
 include $(TOPDIR)/include/builddefs
 
 LTLIBRARY = libmisc.la
-LTLDFLAGS =
+LTLDFLAGS = $(LDFLAGS)
 
 CFILES = quote.c unquote.c high_water_alloc.c next_line.c walk_tree.c
 

Attachment: signature.asc
Description: Digital signature

Reply via email to