Package: 4store
Severity: important
Version: 1.1.4-2
User: debian-rele...@lists.debian.org
Usertags: goal-dash
Control: severity -1 serious

Hi,

I've ran checkbashisms (from the 'devscripts' package) over the whole
archive and I found that your package has a /bin/sh script that uses a
"bashism".

checkbashisms' output:
> possible bashism in ./usr/bin/4s-cluster-file-backup line 14 (should be 'b
> = a'):
> if [ $1 == '--help' ] ; then
> possible bashism in ./usr/bin/4s-cluster-file-backup line 19 (should be 'b
> = a'):
> if [ $1 == '--version' ] ; then
> possible bashism in ./usr/bin/4s-cluster-file-backup line 25 (should be 'b
> = a'):
> if [ $# == 0 ] ; then
> possible bashism in ./usr/bin/4s-cluster-copy line 2 ('((' should be
> '$(('):
> if (($# >= 2)) ; then
> possible bashism in ./usr/bin/4s-ssh-all line 3 (should be 'b = a'):
> if [ "$1" == '--help' ] ; then
> possible bashism in ./usr/bin/4s-ssh-all line 8 (should be 'b = a'):
> if [ "$1" == '--version' ] ; then
> possible bashism in ./usr/bin/4s-ssh-all line 13 (should be 'b = a'):
> if [ $# == 0 ] ; then
> possible bashism in ./usr/bin/4s-ssh-all line 19 (let ...):
> let id=0;
> possible bashism in ./usr/bin/4s-ssh-all line 20 (let ...):
> let nodes=0;
> possible bashism in ./usr/bin/4s-ssh-all line 22 (let ...):
>  let nodes=nodes+1;
> possible bashism in ./usr/bin/4s-ssh-all line 27 (let ...):
>  let id=id+1;
> possible bashism in ./usr/bin/4s-file-backup line 3 (should be 'b = a'):
> if [ $1 == '--help' ] ; then
> possible bashism in ./usr/bin/4s-file-backup line 8 (should be 'b = a'):
> if [ $1 == '--version' ] ; then
> possible bashism in ./usr/bin/4s-file-backup line 13 ('((' should be
> '$(('):
> if (($# == 1)) ; then
> possible bashism in ./usr/bin/4s-cluster-destroy line 3 (should be 'b =
> a'):
> if [ $1 == '--help' ] ; then
> possible bashism in ./usr/bin/4s-cluster-destroy line 8 (should be 'b =
> a'):
> if [ $1 == '--version' ] ; then
> possible bashism in ./usr/bin/4s-cluster-destroy line 14 ('((' should be
> '$(('):
> if (($# == 1)) ; then


Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is the default /bin/sh.

Please closely examine the above output and the script, and determine
what the proper severity of the bug is, and adjust it accordingly. If
it's important or greater please hurry to get this fixed for jessie.

Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh

Thanks in advance,
Raphael Geissert


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to