Bug#693460: Bug#694091: bcrypt: Tries to load whole file into memory regardless of the size

2012-11-30 Thread Michael Stapelberg
Hi Kevin, Kevin Coyner writes: > I've got a package complete but just want to tidy it up and test it a > little more. Thanks. Please keep in mind that packages should have minimal differences to their previous version if we want to get them into wheezy. The more changes you do, the smaller the c

Bug#693460: Bug#694091: bcrypt: Tries to load whole file into memory regardless of the size

2012-11-30 Thread Kevin Coyner
I've got a package complete but just want to tidy it up and test it a little more. Thanks. Kevin On Fri, Nov 30, 2012 at 4:37 AM, Michael Stapelberg wrote: > Hi Kevin, > > Michael Stapelberg writes: > >> I'm on the road right now, but would be happy to upload a new version > later > >> tonight

Bug#693460: Bug#694091: bcrypt: Tries to load whole file into memory regardless of the size

2012-11-30 Thread Michael Stapelberg
Hi Kevin, Michael Stapelberg writes: >> I'm on the road right now, but would be happy to upload a new version later >> tonight or early tomorrow morning. > Thanks. Please let us know when you are done. Any news on that? If you need any help, please tell us. -- Best regards, Michael -- To UN

Bug#693460: Bug#694091: bcrypt: Tries to load whole file into memory regardless of the size

2012-11-26 Thread Michael Stapelberg
Hi Kevin, Kevin Coyner writes: > I'm on the road right now, but would be happy to upload a new version later > tonight or early tomorrow morning. Thanks. Please let us know when you are done. In the meantime, new upstream has merged the fix and also improved error messages and fixed a memory lea

Bug#693460: Bug#694091: bcrypt: Tries to load whole file into memory regardless of the size

2012-11-25 Thread Kevin Coyner
-- Kevin Coyner. GnuPG key: 2048R/C85D8F71 On Nov 25, 2012 12:33 PM, "Michael Stapelberg" wrote: > > > Your patch does seem to work on fixing most of the issues that I had > > identified, and you have tested it thoroughly (I haven't run the tests > > myself, though), so I guess it would be alrigh

Bug#694091: bcrypt: Tries to load whole file into memory regardless of the size

2012-11-25 Thread Michael Stapelberg
Hi Margarita, Margarita Manterola writes: > Please respect the original author indenting style. There hardly is such a thing. The source code as-is uses different indenting styles. But that is a minor nitpick not worthy of discussion. Feel free to change my patch as you see fit. > This should be

Bug#694091: bcrypt: Tries to load whole file into memory regardless of the size

2012-11-24 Thread Michael Stapelberg
Hi, On Fri, 23 Nov 2012 20:41:24 + Margarita Manterola wrote: > The solution to this problem would be to put a limit on how much can > be read and encrypt via various subsequent read/writes instead of > just one big read and one big write. I am currently working on making bcrypt compress and

Bug#694091: bcrypt: Tries to load whole file into memory regardless of the size

2012-11-23 Thread Margarita Manterola
Package: bcrypt Version: 1.1-6 Severity: grave Tags: lfs upstream Hi, The current version of bcrypt reads the whole file into memory by using fread, regardless of the file size. This means that for large files, a machine can run out of memory by trying to just read the file. The out of memory k