Bug#694631: oss4: Review of vmix FPU usage

2012-12-03 Thread Ben Hutchings
On Sun, Dec 02, 2012 at 02:16:40PM +, Ben Hutchings wrote: > I asked H. Peter Anvin (one of the Linux x86 maintainers) to review the > FPU code. This was done on IRC so I'll summarise: > > 1. oss_fp_check() has no need to use kernel_fpu_begin() and > kernel_fpu_end(). But it should use the C

Bug#694631: oss4: Review of vmix FPU usage

2012-12-02 Thread Ben Hutchings
I asked H. Peter Anvin (one of the Linux x86 maintainers) to review the FPU code. This was done on IRC so I'll summarise: 1. oss_fp_check() has no need to use kernel_fpu_begin() and kernel_fpu_end(). But it should use the CPU features API (see arch/x86/include/asm/cpufeature.h). 2. oss_fp_save(