Bug#700700: approx: never logs cache hits even when $verbose is true

2013-03-15 Thread Helmut Grohne
On Thu, Mar 14, 2013 at 08:01:12AM -0400, Eric Cooper wrote: Sorry, I just realized you were asking for cache hit notification when $verbose, but not $debug, is true. Thanks for bearing with me! I'm willing to reconsider that, along with client information in each log message. I'll look

Bug#700700: approx: never logs cache hits even when $verbose is true

2013-03-14 Thread Helmut Grohne
Control: reopen -1 Control: severity -1 wishlist On Fri, Mar 08, 2013 at 01:16:10PM -0500, Eric Cooper wrote: There is a subtle difference between the cached and delivered log messages. In both cases, the file is now in the cache. But delivered means that the file was streamed back to the

Bug#700700: approx: never logs cache hits even when $verbose is true

2013-03-14 Thread Eric Cooper
So cached is not what I'd like to see here. What I'd like to see is some indication that a file was delivered from the cache to the client. At the moment I can reliably reproduce that cache hits are not logged at all. So the reported issue persists. Sorry, I just realized you were asking for

Bug#700700: approx: never logs cache hits even when $verbose is true

2013-02-16 Thread Helmut Grohne
Package: approx Version: 5.3-1 Severity: minor Having set $verbose true in my approx.conf I can see log lines ending in delivered and not found, but I never see any log lines ending in cached even though approx clearly produces cache hits. The source (approx.ml) suggests that cache hits should be