Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Release Team,

Please consider unblocking package navit.

The new release 0.5.0~svn5126+dfsg.1-3 introduces three segfault fixes
related to bugs #682553 and #703110.

Debdiff attached.

Many thanks in advance.

unblock navit/0.5.0~svn5126+dfsg.1-3

- -- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-3-486
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQEcBAEBCAAGBQJRRuXYAAoJEO/obGx//s+D1MkH/Rq6u2/w0O1CrLvX9ml2eoz9
FCMQu5O/ozZYzMPtqd+hB9+WGir6J2yLAngmzCa9vqcPLz6e83fFTJmyXHXQtGi4
+pNtJ4MkK5CuN7MoH1hSK27eygKuNhr+Yl6Mah9SVVKp4r6DXX9vn3nxKvGRbrsQ
vf//GC8A7LB7yW/V9vO1Lh/pAFh2nDL6c8FJ/9RYE4F4gPxScQN1W91C1sHI95Bn
V4eBtTmJuccZvzj8dEOmudBN8lawI7RjvM1IhqNGiXXZbhkWHZTSXqu4EQwIBkb3
lfRfTbhG0y7y/DWxB5i/DBHWW6w+rCRbmBlAb2lJT/YiWNBvATTYUBkGNlZyn80=
=C0Fa
-----END PGP SIGNATURE-----
diff -Nru navit-0.5.0~svn5126+dfsg.1/debian/changelog navit-0.5.0~svn5126+dfsg.1/debian/changelog
--- navit-0.5.0~svn5126+dfsg.1/debian/changelog	2012-06-09 22:11:21.000000000 +0200
+++ navit-0.5.0~svn5126+dfsg.1/debian/changelog	2013-03-17 17:49:14.000000000 +0100
@@ -1,3 +1,16 @@
+navit (0.5.0~svn5126+dfsg.1-3) unstable; urgency=low
+
+  * New patches:
+    + maptool-uninitialised-values.patch:
+      Fix segfault in maptool due to uninitialised values (Closes: #682553)
+    + keep-null-gps-vehicle.patch:
+      Don't deactivate Null GPS vehicle when position is set manually
+      (fix a segfault)
+    + check-empty-dest-map.patch:
+      Don't remove previous destination when there is none (Closes: #703110)
+
+ -- Gilles Filippini <p...@debian.org>  Sun, 17 Mar 2013 17:49:06 +0100
+
 navit (0.5.0~svn5126+dfsg.1-2) unstable; urgency=low
 
   * d/rules:
diff -Nru navit-0.5.0~svn5126+dfsg.1/debian/patches/check-empty-dest-map.patch navit-0.5.0~svn5126+dfsg.1/debian/patches/check-empty-dest-map.patch
--- navit-0.5.0~svn5126+dfsg.1/debian/patches/check-empty-dest-map.patch	1970-01-01 01:00:00.000000000 +0100
+++ navit-0.5.0~svn5126+dfsg.1/debian/patches/check-empty-dest-map.patch	2013-03-17 16:33:53.000000000 +0100
@@ -0,0 +1,25 @@
+Description: Don't remove last dest when destination map is empty
+Author: Gilles Filippini <p...@debian.org>
+Bug-Debian: http://bugs.debian.org/703110
+Last-Update: 2013-03-12
+Index: navit/navit/bookmarks.c
+===================================================================
+--- navit.orig/navit/bookmarks.c	2013-03-11 23:55:15.000000000 +0100
++++ navit/navit/bookmarks.c	2013-03-12 19:53:34.000000000 +0100
+@@ -797,10 +797,12 @@
+ 
+ 	/* First, remove the last former_destination */
+ 	former_destinations = read_former_destination_map_as_list(former_destination_map);
+-	dest = g_list_last(former_destinations)->data;
+-	former_destinations = g_list_remove(former_destinations, dest);
+-	free_former_destination(dest);
+-	write_former_destinations(former_destinations, former_destination_file, map_projection(former_destination_map));
++	if (former_destinations != NULL) {
++		dest = g_list_last(former_destinations)->data;
++		former_destinations = g_list_remove(former_destinations, dest);
++		free_former_destination(dest);
++		write_former_destinations(former_destinations, former_destination_file, map_projection(former_destination_map));
++	}
+ 
+ 	/* Then, append the new one */
+ 	bookmarks_append_destinations(former_destination_map, former_destination_file, c, count, type, description, limit);
diff -Nru navit-0.5.0~svn5126+dfsg.1/debian/patches/keep-null-gps-vehicle.patch navit-0.5.0~svn5126+dfsg.1/debian/patches/keep-null-gps-vehicle.patch
--- navit-0.5.0~svn5126+dfsg.1/debian/patches/keep-null-gps-vehicle.patch	1970-01-01 01:00:00.000000000 +0100
+++ navit-0.5.0~svn5126+dfsg.1/debian/patches/keep-null-gps-vehicle.patch	2013-03-17 17:39:16.000000000 +0100
@@ -0,0 +1,19 @@
+Description: Don't unset vehicle profile on set_position
+ set_position with no vehicle profile segfaults.
+Author: Gilles Filippini <p...@debian.org>
+Last-Update: 2013-03-17
+Index: navit/navit/gui/internal/gui_internal.c
+===================================================================
+--- navit.orig/navit/gui/internal/gui_internal.c	2013-03-17 16:36:36.000000000 +0100
++++ navit/navit/gui/internal/gui_internal.c	2013-03-17 16:42:25.000000000 +0100
+@@ -3736,7 +3736,9 @@
+ 		struct attr vehicle, source;
+ 		int deactivate=0;
+ 		if (navit_get_attr(this->nav, attr_vehicle, &vehicle, NULL) && vehicle.u.vehicle && 
+-				!(vehicle_get_attr(vehicle.u.vehicle, attr_source, &source, NULL) && source.u.str && !strcmp("demo://",source.u.str))) 
++				!(vehicle_get_attr(vehicle.u.vehicle, attr_source, &source, NULL) && source.u.str &&
++					!strcmp("demo://",source.u.str) &&
++					!strcmp("null://",source.u.str))) 
+ 			deactivate=1;
+ 
+ 		text=deactivate? _("Set as position (and deactivate vehicle)") : _("Set as position");
diff -Nru navit-0.5.0~svn5126+dfsg.1/debian/patches/maptool-uninitialised-values.patch navit-0.5.0~svn5126+dfsg.1/debian/patches/maptool-uninitialised-values.patch
--- navit-0.5.0~svn5126+dfsg.1/debian/patches/maptool-uninitialised-values.patch	1970-01-01 01:00:00.000000000 +0100
+++ navit-0.5.0~svn5126+dfsg.1/debian/patches/maptool-uninitialised-values.patch	2012-07-28 11:13:05.000000000 +0200
@@ -0,0 +1,16 @@
+Description: Fix maptool segfault due to uninitialised values
+Author: Gilles Filippini <p...@debian.org>
+Bug-Debian: http://bugs.debian.org/682553
+Index: navit/navit/maptool/osm.c
+===================================================================
+--- navit.orig/navit/maptool/osm.c	2012-06-06 08:10:49.562757866 +0200
++++ navit/navit/maptool/osm.c	2012-07-24 23:10:59.385989146 +0200
+@@ -2151,7 +2151,7 @@
+ 	GList *l=tr;
+ 	while (l) {
+ 		struct turn_restriction *t=l->data;
+-		struct coord *c[4];
++		struct coord *c[4] = { NULL };
+ 		struct item_bin *ib=item_bin;
+ 
+ 		if (!t->c_count[0]) {
diff -Nru navit-0.5.0~svn5126+dfsg.1/debian/patches/series navit-0.5.0~svn5126+dfsg.1/debian/patches/series
--- navit-0.5.0~svn5126+dfsg.1/debian/patches/series	2012-06-09 15:43:29.000000000 +0200
+++ navit-0.5.0~svn5126+dfsg.1/debian/patches/series	2013-03-17 17:39:50.000000000 +0100
@@ -8,3 +8,6 @@
 dpkg-cross.patch
 qt-qpainter-missing-symbol.patch
 taking-address-of-temporary-array.patch
+maptool-uninitialised-values.patch
+keep-null-gps-vehicle.patch
+check-empty-dest-map.patch

Reply via email to