Source: ruby-mini-magick Version: 3.5.0-1 Severity: serious Tags: patch Justification: fails to build from source
This package requires internet connectivity for its test suite to pass. Package builds should not rely on external network connectivity, but should be self-contained. I have attached a simple patch that removes the offending test methods. Build log: Loaded suite debian/ruby-tests Started .......................................E =============================================================================== Error: test_remote_image(ImageTest) SocketError: getaddrinfo: Name or service not known /usr/lib/ruby/1.8/net/http.rb:560:in `initialize' 557: 558: def connect 559: D "opening connection to #{conn_address()}..." => 560: s = timeout(@open_timeout) { TCPSocket.open(conn_address(), conn_port()) } 561: D "opened" 562: if use_ssl? 563: unless @ssl_context.verify_mode /usr/lib/ruby/1.8/net/http.rb:560:in `open' /usr/lib/ruby/1.8/net/http.rb:560:in `connect' /usr/lib/ruby/1.8/timeout.rb:53:in `timeout' /usr/lib/ruby/1.8/timeout.rb:101:in `timeout' /usr/lib/ruby/1.8/net/http.rb:560:in `connect' /usr/lib/ruby/1.8/net/http.rb:553:in `do_start' /usr/lib/ruby/1.8/net/http.rb:542:in `start' /usr/lib/ruby/1.8/open-uri.rb:242:in `open_http' /usr/lib/ruby/1.8/open-uri.rb:616:in `buffer_open' /usr/lib/ruby/1.8/open-uri.rb:164:in `open_loop' /usr/lib/ruby/1.8/open-uri.rb:162:in `catch' /usr/lib/ruby/1.8/open-uri.rb:162:in `open_loop' /usr/lib/ruby/1.8/open-uri.rb:132:in `open_uri' /usr/lib/ruby/1.8/open-uri.rb:518:in `open' /usr/lib/ruby/1.8/open-uri.rb:30:in `open' /build/buildd/ruby-mini-magick-3.5.0/lib/mini_magick.rb:126:in `open' ../test/image_test.rb:59:in `test_remote_image' =============================================================================== E =============================================================================== Error: test_remote_image_with_complex_url(ImageTest) SocketError: getaddrinfo: Name or service not known /usr/lib/ruby/1.8/net/http.rb:560:in `initialize' 557: 558: def connect 559: D "opening connection to #{conn_address()}..." => 560: s = timeout(@open_timeout) { TCPSocket.open(conn_address(), conn_port()) } 561: D "opened" 562: if use_ssl? 563: unless @ssl_context.verify_mode /usr/lib/ruby/1.8/net/http.rb:560:in `open' /usr/lib/ruby/1.8/net/http.rb:560:in `connect' /usr/lib/ruby/1.8/timeout.rb:53:in `timeout' /usr/lib/ruby/1.8/timeout.rb:101:in `timeout' /usr/lib/ruby/1.8/net/http.rb:560:in `connect' /usr/lib/ruby/1.8/net/http.rb:553:in `do_start' /usr/lib/ruby/1.8/net/http.rb:542:in `start' /usr/lib/ruby/1.8/open-uri.rb:242:in `open_http' /usr/lib/ruby/1.8/open-uri.rb:616:in `buffer_open' /usr/lib/ruby/1.8/open-uri.rb:164:in `open_loop' /usr/lib/ruby/1.8/open-uri.rb:162:in `catch' /usr/lib/ruby/1.8/open-uri.rb:162:in `open_loop' /usr/lib/ruby/1.8/open-uri.rb:132:in `open_uri' /usr/lib/ruby/1.8/open-uri.rb:518:in `open' /usr/lib/ruby/1.8/open-uri.rb:30:in `open' /build/buildd/ruby-mini-magick-3.5.0/lib/mini_magick.rb:126:in `open' ../test/image_test.rb:65:in `test_remote_image_with_complex_url' =============================================================================== ....... Finished in 1.306837 seconds. 46 tests, 65 assertions, 0 failures, 2 errors, 0 pendings, 0 omissions, 0 notifications 95.6522% passed 35.20 tests/s, 49.74 assertions/s ERROR: Test "ruby1.8" failed. Exiting.
Description: Remove tests that require internet connectivity. Author: Felix Geyer <fge...@debian.org> --- ruby-mini-magick-3.5.0.orig/test/image_test.rb +++ ruby-mini-magick-3.5.0/test/image_test.rb @@ -55,18 +55,6 @@ class ImageTest < Test::Unit::TestCase image.destroy! end - def test_remote_image - image = Image.open("http://upload.wikimedia.org/wikipedia/en/b/bc/Wiki.png") - assert image.valid? - image.destroy! - end - - def test_remote_image_with_complex_url - image = Image.open("http://a0.twimg.com/a/1296609216/images/fronts/logo_withbird_home.png?extra=foo&plus=bar") - assert image.valid? - image.destroy! - end - def test_reformat_with_capitalized_extension image = Image.open(CAP_EXT_PATH) image.format "jpg"