Package: maven-repo-helper
Severity: important
Tags: patch

Because of recent changes in POMReader.java, values parsed from XML keep their
leading and trailing whitespace.

Consequently, a malformed .mh/pom.properties is created for example from 
pom.xml[1],
causing a build failure.

I propose a very simple patch to fix this issue.

Regards,

Jakub

[1] 
http://anonscm.debian.org/viewvc/pkg-java/trunk/bnd/debian/pom.xml?revision=15264&view=markup
>From 784c41c79cfa7d1ca660a2a2a4237b88bb043a54 Mon Sep 17 00:00:00 2001
From: Jakub Adam <jakub.a...@ktknet.cz>
Date: Tue, 18 Jun 2013 12:54:23 +0200
Subject: [PATCH] Trim whitespace from values in POMReader

---
 src/main/java/org/debian/maven/repo/POMReader.java |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/debian/maven/repo/POMReader.java b/src/main/java/org/debian/maven/repo/POMReader.java
index cc2f4ce..47b2408 100644
--- a/src/main/java/org/debian/maven/repo/POMReader.java
+++ b/src/main/java/org/debian/maven/repo/POMReader.java
@@ -103,7 +103,7 @@ public class POMReader {
                 }
 
                 case XMLStreamConstants.END_ELEMENT: {
-                    String value = buffer != null ? buffer.toString() : null;
+                    String value = buffer != null ? buffer.toString().trim() : null;
                     if (inIgnoredElement > 0 || path.contains("exclusions")) {
                         // ignore
                     } else if (path.contains("dependency") || path.contains("plugin") || path.contains("extension")) {
-- 
1.7.10.4

Reply via email to